emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature/native-comp 58d85f4 2/3: * Do use echo area for async compilatio


From: Andrea Corallo
Subject: feature/native-comp 58d85f4 2/3: * Do use echo area for async compilation started/finished messages
Date: Wed, 7 Oct 2020 10:45:06 -0400 (EDT)

branch: feature/native-comp
commit 58d85f4dbb878eca08c770b9de8f734ca78840db
Author: Andrea Corallo <akrl@sdf.org>
Commit: Andrea Corallo <akrl@sdf.org>

    * Do use echo area for async compilation started/finished messages
    
        * lisp/emacs-lisp/comp.el (comp-run-async-workers)
        (native-compile-async): Do not write into the echo area.
---
 lisp/emacs-lisp/comp.el | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 7074ff7..01ffd4d 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2783,16 +2783,14 @@ display a message."
          when (>= (comp-async-runnings) (comp-effective-async-max-jobs))
            do (cl-return)))
     ;; No files left to compile and all processes finished.
-    (let ((msg "Compilation finished."))
-      (run-hooks 'comp-async-all-done-hook)
-      (with-current-buffer (get-buffer-create comp-async-buffer-name)
-        (save-excursion
-          (goto-char (point-max))
-          (insert msg "\n")))
-      ;; `comp-deferred-pending-h' should be empty at this stage.
-      ;; Reset it anyway.
-      (clrhash comp-deferred-pending-h)
-      (message msg))))
+    (run-hooks 'comp-async-all-done-hook)
+    (with-current-buffer (get-buffer-create comp-async-buffer-name)
+      (save-excursion
+        (goto-char (point-max))
+        (insert "Compilation finished.\n")))
+    ;; `comp-deferred-pending-h' should be empty at this stage.
+    ;; Reset it anyway.
+    (clrhash comp-deferred-pending-h)))
 
 
 ;;; Compiler entry points.
@@ -2928,8 +2926,7 @@ queued with LOAD %"
                                (format "No write access for %s skipping."
                                        out-filename)))))))
     (when (zerop (comp-async-runnings))
-      (comp-run-async-workers)
-      (message "Compilation started."))))
+      (comp-run-async-workers))))
 
 (provide 'comp)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]