emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-27 9b47ae2: Don't error if no GPG signing key configured


From: Robert Pluim
Subject: emacs-27 9b47ae2: Don't error if no GPG signing key configured
Date: Fri, 2 Oct 2020 04:48:05 -0400 (EDT)

branch: emacs-27
commit 9b47ae23043d952780fc15da6540444ccddd4f58
Author: Robert Pluim <rpluim@gmail.com>
Commit: Robert Pluim <rpluim@gmail.com>

    Don't error if no GPG signing key configured
    
    * lisp/gnus/mml-sec.el (mml-secure-epg-sign): Partially revert
    "Make mml-secure-epg-sign bug out if we can't find an identity".
    It causes signing to fail for people who have not set up
    mml-secure-{smime,openpgp}-sign-with-sender, which is a regression
    from Emacs-26 (Bug#40118).  In such a situation gpg will use its
    default key.
    
    Do not merge to master. On master Emacs will query the user.
---
 lisp/gnus/mml-sec.el | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 740e1d2..8d77916 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -944,16 +944,6 @@ If no one is selected, symmetric encryption will be 
performed.  "
         (signer-names (mml-secure-signer-names protocol sender))
         (signers (mml-secure-signers context signer-names))
         signature micalg)
-    (unless signers
-      (let ((maybe-msg
-             (if mml-secure-smime-sign-with-sender
-                 "."
-               "; try setting `mml-secure-smime-sign-with-sender'.")))
-        ;; If `mml-secure-smime-sign-with-sender' is already non-nil
-        ;; then there's no point advising the user to examine it.  If
-        ;; there are any other variables worth examining, please
-        ;; improve this error message by having it mention them.
-        (error "Couldn't find any signer names%s" maybe-msg)))
     (when (eq 'OpenPGP protocol)
       (setf (epg-context-armor context) t)
       (setf (epg-context-textmode context) t)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]