[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/icomplete-vertical 2e757af 11/20: Improve vertical height calcul
From: |
Jimmy Aguilar Mena |
Subject: |
feature/icomplete-vertical 2e757af 11/20: Improve vertical height calculation when not in minibuffer |
Date: |
Fri, 18 Sep 2020 13:00:02 -0400 (EDT) |
branch: feature/icomplete-vertical
commit 2e757af1144c8f26d82119671c5c8dc308327fe3
Author: Jimmy Aguilar Mena <spacibba@aol.com>
Commit: Jimmy Aguilar Mena <spacibba@aol.com>
Improve vertical height calculation when not in minibuffer
* lisp/icomplete.el (icomplete--vertical-get-max-height): new function
to calculate the vertical-max-height.
---
lisp/icomplete.el | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index ef46fd5..3d6e649 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -516,6 +516,20 @@ Conditions are:
map)
"Keymap used by `fido-mode' and `icomplete-mode' in
`icomplete-vertical-mode'.")
+(defun icomplete--vertical-get-max-height ()
+ (let ((minibuffer-parameter (frame-parameter nil 'minibuffer)))
+ (cond
+ ((eq minibuffer-parameter t)
+ (cond ((floatp max-mini-window-height)
+ (floor (* max-mini-window-height (frame-pixel-height))))
+ ((integerp max-mini-window-height)
+ (floor (* max-mini-window-height line-height)))
+ (t
+ (* icomplete-prospects-height line-height))))
+ ((eq minibuffer-parameter 'only)
+ (frame-pixel-height))
+ ;; TODO: minibuffer-parameter can also be a window or a frame; Add
conditions framep and windowp
+ )))
(defun icomplete--vertical-prospects (match-braket prefix most _determ comps)
"List of vertical completions limited."
@@ -526,12 +540,7 @@ Conditions are:
(string-prefix-p prefix most t)
(length prefix)))
(line-height (line-pixel-height))
- (prospects-max-height (cond ((floatp max-mini-window-height)
- (floor (* max-mini-window-height
(frame-pixel-height))))
- ((integerp max-mini-window-height)
- (floor (* max-mini-window-height
line-height)))
- (t
- (* icomplete-prospects-height
line-height))))
+ (prospects-max-height icomplete--vertical-get-max-height)
;; prompt + row new line around match
(prospects-rows-pixel (* (1+ (cl-count ?\n match-braket))
line-height))
limit prospects comp)
- branch feature/icomplete-vertical created (now 3ae232d), Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 6df116e 02/20: WIP_minor, Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 6194070 04/20: Icomplete-vertical fix first candidate and icomplete-hide-common-prefix., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 8bf2245 17/20: Fix error in formatting when completion was function %, Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 91dabb1 01/20: Add variables for icomplete indicators., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 385c9d3 03/20: Improve icomplete-vertical implementation., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical ca1d6ee 07/20: icomplete add item format., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 1743b757 19/20: icomplete--format-function process substring with prefix., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 2e757af 11/20: Improve vertical height calculation when not in minibuffer,
Jimmy Aguilar Mena <=
- feature/icomplete-vertical 2ca463f 13/20: Improve formated size calculation, Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 785d32a 18/20: Icomplete vertical respect icomplete-hide-common-prefix., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 0c2cff3 14/20: convert icomplete-tidy-shadowed-file-names in a custom, Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 8a3ee9a 10/20: Fix icomplete prompt not visible in icomplete-vertical (bug#24293), Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 98d65aa 06/20: Add modified local map for icomplete., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 9f6dfd8 12/20: Fix previous commit., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 2f1dcaa 15/20: Make some variable local or custom., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical fd92ea8 09/20: Add special management of first candidate, Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical d1b38d8 08/20: Add icomplete--format-function to format items., Jimmy Aguilar Mena, 2020/09/18
- feature/icomplete-vertical 12b45f4 05/20: icomplete-vertical code simplify, Jimmy Aguilar Mena, 2020/09/18