[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master ccd5f0d: Fix eww-change-select defaults in a different way
From: |
Lars Ingebrigtsen |
Subject: |
master ccd5f0d: Fix eww-change-select defaults in a different way |
Date: |
Sat, 5 Sep 2020 20:02:53 -0400 (EDT) |
branch: master
commit ccd5f0d0a99f93c5507c888b5a0c1a5af2d89106
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>
Fix eww-change-select defaults in a different way
* lisp/net/eww.el (eww-change-select): Fix bug#43218 in a more
safe way than the previous version.
---
lisp/net/eww.el | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index b800d18..4b897fa3 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1450,14 +1450,13 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
(cons (plist-get (cdr elem) :display)
(plist-get (cdr elem) :value))))
input)))
- (display
- (completing-read "Change value: " options nil 'require-match
- nil nil (car (rassoc (plist-get input :value)
- options))))
+ (display (completing-read "Change value: " options nil 'require-match))
(inhibit-read-only t))
- (plist-put input :value (cdr (assoc-string display options t)))
- (goto-char
- (eww-update-field display))))
+ ;; If the user doesn't enter anything, don't change anything.
+ (when (> (length display) 0)
+ (plist-put input :value (cdr (assoc-string display options t)))
+ (goto-char
+ (eww-update-field display)))))
(defun eww-update-field (string &optional offset)
(unless offset
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master ccd5f0d: Fix eww-change-select defaults in a different way,
Lars Ingebrigtsen <=