[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master b9bdc48: Fix <optgroup> in selects in eww
From: |
Lars Ingebrigtsen |
Subject: |
master b9bdc48: Fix <optgroup> in selects in eww |
Date: |
Sat, 5 Sep 2020 09:42:36 -0400 (EDT) |
branch: master
commit b9bdc48b4c79c88e36216b404997084fecf1bed2
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>
Fix <optgroup> in selects in eww
* lisp/net/eww.el (eww-tag-select): Use all the options. This
fixes the problem with <optgroup> elements that wrap them (bug#43217).
---
lisp/net/eww.el | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 04deb5b..dedf1c6 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1402,16 +1402,15 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
(options nil)
(start (point))
(max 0))
- (dolist (elem (dom-non-text-children dom))
- (when (eq (dom-tag elem) 'option)
- (when (dom-attr elem 'selected)
- (nconc menu (list :value (dom-attr elem 'value))))
- (let ((display (dom-text elem)))
- (setq max (max max (length display)))
- (push (list 'item
- :value (dom-attr elem 'value)
- :display display)
- options))))
+ (dolist (elem (dom-by-tag dom 'option))
+ (when (dom-attr elem 'selected)
+ (nconc menu (list :value (dom-attr elem 'value))))
+ (let ((display (dom-text elem)))
+ (setq max (max max (length display)))
+ (push (list 'item
+ :value (dom-attr elem 'value)
+ :display display)
+ options)))
(when options
(setq options (nreverse options))
;; If we have no selected values, default to the first value.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master b9bdc48: Fix <optgroup> in selects in eww,
Lars Ingebrigtsen <=