emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 1fe1c84 2/2: Small cleanup


From: Dmitry Gutov
Subject: master 1fe1c84 2/2: Small cleanup
Date: Tue, 2 Jun 2020 17:33:22 -0400 (EDT)

branch: master
commit 1fe1c84b188336e5a94b77f64d5906beac3446f2
Author: Dmitry Gutov <dgutov@yandex.ru>
Commit: Dmitry Gutov <dgutov@yandex.ru>

    Small cleanup
    
    * lisp/progmodes/project.el (project--add-to-project-list-front):
    Small simplification.
    (project--remove-from-project-list): Remove oudated comment.
---
 lisp/progmodes/project.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 1c4dc7e..bd99d5b 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -787,9 +787,9 @@ Save the result to disk if the project list was changed."
   (project--ensure-read-project-list)
   (let* ((dir (project-root pr))
          (do-write (not (equal (car project--list) dir))))
-    (setq project--list (delete dir project--list))
-    (push dir project--list)
     (when do-write
+      (setq project--list (delete dir project--list))
+      (push dir project--list)
       (project--write-project-list))))
 
 (defun project--remove-from-project-list (pr-dir)
@@ -797,8 +797,6 @@ Save the result to disk if the project list was changed."
 If the directory was in the list before the removal, save the
 result to disk."
   (project--ensure-read-project-list)
-  ;; XXX: This hardcodes that the number of roots = 1.
-  ;; It's fine, though.
   (when (member pr-dir project--list)
     (setq project--list (delete pr-dir project--list))
     (message "Project `%s' not found; removed from list" pr-dir)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]