emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master f373cec: Fix uses of inhibit-message in package.el


From: Eli Zaretskii
Subject: master f373cec: Fix uses of inhibit-message in package.el
Date: Fri, 22 Nov 2019 09:37:30 -0500 (EST)

branch: master
commit f373cec7f51653130bff0844262d356c2bf7c649
Author: Eli Zaretskii <address@hidden>
Commit: Eli Zaretskii <address@hidden>

    Fix uses of inhibit-message in package.el
    
    * lisp/emacs-lisp/package.el (package-generate-autoloads)
    (package--compile, package--save-selected-packages): Don't use
    'inhibit-message' to bind 'noninteractive' and 'save-silently',
    since 'inhibit-message' already disables all messages.
    (Bug#38264)
---
 lisp/emacs-lisp/package.el | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 26207e0..56e1602 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1002,8 +1002,6 @@ untar into a directory named DIR; otherwise, signal an 
error."
          (generated-autoload-file (expand-file-name auto-name pkg-dir))
          ;; We don't need 'em, and this makes the output reproducible.
          (autoload-timestamps nil)
-         ;; Silence `autoload-generate-file-autoloads'.
-         (noninteractive inhibit-message)
          (backup-inhibited t)
          (version-control 'never))
     (package-autoload-ensure-default-file generated-autoload-file)
@@ -1029,7 +1027,6 @@ untar into a directory named DIR; otherwise, signal an 
error."
 This assumes that `pkg-desc' has already been activated with
 `package-activate-1'."
   (let ((warning-minimum-level :error)
-        (save-silently inhibit-message)
         (load-path load-path))
     (byte-recompile-directory (package-desc-dir pkg-desc) 0 t)))
 
@@ -1840,8 +1837,7 @@ Used to populate `package-selected-packages'."
   (when value
     (setq package-selected-packages value))
   (if after-init-time
-      (let ((save-silently inhibit-message))
-        (customize-save-variable 'package-selected-packages 
package-selected-packages))
+      (customize-save-variable 'package-selected-packages 
package-selected-packages)
     (add-hook 'after-init-hook #'package--save-selected-packages)))
 
 (defun package--user-selected-p (pkg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]