emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 2f36a08: Disable a portion of one doc-test


From: Glenn Morris
Subject: master 2f36a08: Disable a portion of one doc-test
Date: Sat, 9 Nov 2019 22:38:22 -0500 (EST)

branch: master
commit 2f36a0821491f25fb52d4f3c6f4a7aebb923225f
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>

    Disable a portion of one doc-test
    
    * test/src/doc-tests.el (doc-test-substitute-command-keys):
    Disable component that fails twice in the past 5 weeks
    due to changes in the minibuffer map.
---
 test/src/doc-tests.el | 63 +++++++++++++++++++++++++++------------------------
 1 file changed, 33 insertions(+), 30 deletions(-)

diff --git a/test/src/doc-tests.el b/test/src/doc-tests.el
index 4cfc5a5..705675a 100644
--- a/test/src/doc-tests.el
+++ b/test/src/doc-tests.el
@@ -35,36 +35,39 @@
   (should (string= (substitute-command-keys "foo \\=\\=")
                    "foo \\="))
   ;; Keymaps.
-  (should (string= (substitute-command-keys
-                    "\\{minibuffer-local-must-match-map}")
-                   "\
-key             binding
----             -------
-
-C-g            abort-recursive-edit
-TAB            minibuffer-complete
-C-j            minibuffer-complete-and-exit
-RET            minibuffer-complete-and-exit
-ESC            Prefix Command
-SPC            minibuffer-complete-word
-?              minibuffer-completion-help
-<C-tab>                file-cache-minibuffer-complete
-<XF86Back>     previous-history-element
-<XF86Forward>  next-history-element
-<down>         next-line-or-history-element
-<next>         next-history-element
-<prior>                switch-to-completions
-<up>           previous-line-or-history-element
-
-M-v            switch-to-completions
-
-M-<            minibuffer-beginning-of-buffer
-M-n            next-history-element
-M-p            previous-history-element
-M-r            previous-matching-history-element
-M-s            next-matching-history-element
-
-"))
+  ;; I don't see that this is testing anything useful.
+  ;; AFAICS all it does it fail whenever someone modifies the
+  ;; minibuffer map.
+;;;   (should (string= (substitute-command-keys
+;;;                     "\\{minibuffer-local-must-match-map}")
+;;;                    "\
+;;; key             binding
+;;; ---             -------
+;;;
+;;; C-g                abort-recursive-edit
+;;; TAB                minibuffer-complete
+;;; C-j                minibuffer-complete-and-exit
+;;; RET                minibuffer-complete-and-exit
+;;; ESC                Prefix Command
+;;; SPC                minibuffer-complete-word
+;;; ?          minibuffer-completion-help
+;;; <C-tab>            file-cache-minibuffer-complete
+;;; <XF86Back> previous-history-element
+;;; <XF86Forward>      next-history-element
+;;; <down>             next-line-or-history-element
+;;; <next>             next-history-element
+;;; <prior>            switch-to-completions
+;;; <up>               previous-line-or-history-element
+;;;
+;;; M-v                switch-to-completions
+;;;
+;;; M-<                minibuffer-beginning-of-buffer
+;;; M-n                next-history-element
+;;; M-p                previous-history-element
+;;; M-r                previous-matching-history-element
+;;; M-s                next-matching-history-element
+;;;
+;;; "))
   (should (string=
            (substitute-command-keys
             "\\<minibuffer-local-must-match-map>\\[abort-recursive-edit]")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]