emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 88f193e 1/3: Improve fix for icomplete's backward-kill-word bug#3


From: João Távora
Subject: master 88f193e 1/3: Improve fix for icomplete's backward-kill-word bug#38024
Date: Fri, 1 Nov 2019 22:39:35 -0400 (EDT)

branch: master
commit 88f193ed05649b8c622867b8b2623b8cb08fdc96
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Improve fix for icomplete's backward-kill-word bug#38024
    
    * lisp/icomplete.el (icomplete-exhibit): Use
    while-no-input-ignore-events, not redisplay.
    
    Co-authored-by: Stefan Monnier <address@hidden>
---
 lisp/icomplete.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 02eae55..89318ca 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -399,8 +399,6 @@ Should be run via minibuffer `post-command-hook'.
 See `icomplete-mode' and `minibuffer-setup-hook'."
   (when (and icomplete-mode
              (icomplete-simple-completing-p)) ;Shouldn't be necessary.
-    (redisplay)     ; FIXME: why is this sometimes needed when moving
-                    ; up dirs in a file-finding table?
     (save-excursion
       (goto-char (point-max))
                                         ; Insert the match-status information:
@@ -420,6 +418,11 @@ See `icomplete-mode' and `minibuffer-setup-hook'."
                ;; embarking on computing completions:
                (sit-for icomplete-compute-delay)))
          (let* ((field-string (icomplete--field-string))
+                 ;; Not sure why, but such requests seem to come
+                 ;; every once in a while.  It's not fully
+                 ;; deterministic but `C-x C-f M-DEL M-DEL ...'
+                 ;; seems to trigger it fairly often!
+                 (while-no-input-ignore-events '(selection-request))
                  (text (while-no-input
                          (icomplete-completions
                           field-string



reply via email to

[Prev in Thread] Current Thread [Next in Thread]