emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master b0af024: Disable pause/resume from menu in snake an


From: Stefan Kangas
Subject: [Emacs-diffs] master b0af024: Disable pause/resume from menu in snake and tetris
Date: Sun, 20 Oct 2019 13:09:54 -0400 (EDT)

branch: master
commit b0af024bb7b2c652ceeb60789edcf4c2bf8c0605
Author: Stefan Kangas <address@hidden>
Commit: Stefan Kangas <address@hidden>

    Disable pause/resume from menu in snake and tetris
    
    * lisp/play/tetris.el (tetris--menu-def):
    * lisp/play/snake.el (snake--menu-def): Disable pause/resume from
    menu.
---
 lisp/play/snake.el  | 17 +++++++++++------
 lisp/play/tetris.el | 17 +++++++++++------
 2 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/lisp/play/snake.el b/lisp/play/snake.el
index 5e8a718..d645f96 100644
--- a/lisp/play/snake.el
+++ b/lisp/play/snake.el
@@ -202,12 +202,17 @@ and then start moving it leftwards.")
     ["End game"       snake-end-game
      :active (snake-active-p)
      :help "End the current Snake game"]
-    ["Pause"          snake-pause-game
-     :active (and (snake-active-p) (not snake-paused))
-     :help "Pause running Snake game"]
-    ["Resume"         snake-pause-game
-     :active (and (snake-active-p) snake-paused)
-     :help "Resume paused Snake game"])
+    ;; FIXME: Pause and resume from the menu currently doesn't work
+    ;;        very well and is therefore disabled.  The game continues
+    ;;        running while navigating the menu.  See also
+    ;;        `tetris--menu-def' which has the same problem.
+    ;; ["Pause"          snake-pause-game
+    ;;  :active (and (snake-active-p) (not snake-paused))
+    ;;  :help "Pause running Snake game"]
+    ;; ["Resume"         snake-pause-game
+    ;;  :active (and (snake-active-p) snake-paused)
+    ;;  :help "Resume paused Snake game"]
+    )
   "Menu for `snake'.  Used to initialize menus.")
 
 (easy-menu-define
diff --git a/lisp/play/tetris.el b/lisp/play/tetris.el
index b5b7772..ea42e12 100644
--- a/lisp/play/tetris.el
+++ b/lisp/play/tetris.el
@@ -289,12 +289,17 @@ each one of its four blocks.")
     ["End game"          tetris-end-game
      :active (tetris-active-p)
      :help "End the current Tetris game"]
-    ["Pause"             tetris-pause-game
-     :active (and (tetris-active-p) (not tetris-paused))
-     :help "Pause running Tetris game"]
-    ["Resume"            tetris-pause-game
-     :active (and (tetris-active-p) tetris-paused)
-     :help "Resume paused Tetris game"])
+    ;; FIXME: Pause and resume from the menu currently doesn't work
+    ;;        very well and is therefore disabled.  The game continues
+    ;;        running while navigating the menu.  See also
+    ;;        `snake--menu-def' which has the same problem.
+    ;; ["Pause"             tetris-pause-game
+    ;;  :active (and (tetris-active-p) (not tetris-paused))
+    ;;  :help "Pause running Tetris game"]
+    ;; ["Resume"            tetris-pause-game
+    ;;  :active (and (tetris-active-p) tetris-paused)
+    ;;  :help "Resume paused Tetris game"]
+    )
   "Menu for `tetris'.  Used to initialize menus.")
 
 (easy-menu-define



reply via email to

[Prev in Thread] Current Thread [Next in Thread]