[Emacs-diffs] master 91c7c6a: Avoid deleting closing quotation mark in checkdoc

[Lars Ingebrigtsen]

branch: master
commit 91c7c6a60260e3820d8f4bac1e17dbec382968f9
Author: Alex Branham <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>

    Avoid deleting closing quotation mark in checkdoc
    
    * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
    Remove calls to delete-region to avoid deleting final " (bug#26328).
---
 lisp/emacs-lisp/checkdoc.el | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el
index 830743f..3c699750 100644
--- a/lisp/emacs-lisp/checkdoc.el
+++ b/lisp/emacs-lisp/checkdoc.el
@@ -1494,16 +1494,11 @@ may require more formatting")
               (if (and (re-search-forward "[.!?:\"]\\([ \t\n]+\\|\"\\)"
                                           (line-end-position) t)
                        (< (current-column) numc))
-                  (if (checkdoc-autofix-ask-replace
-                       p (1+ p)
-                       "1st line not a complete sentence.  Join these lines? "
-                       " " t)
-                      (progn
-                        ;; They said yes.  We have more fill work to do...
-                        (goto-char (match-beginning 1))
-                        (delete-region (point) (match-end 1))
-                        (insert "\n")
-                        (setq msg nil))))))
+                  (when (checkdoc-autofix-ask-replace
+                         p (1+ p)
+                         "1st line not a complete sentence.  Join these lines? 
"
+                         " " t)
+                    (setq msg nil)))))
           (if msg
               (checkdoc-create-error msg s (save-excursion
                                              (goto-char s)