emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master b5376e0 2/2: Skip tests if test subdir is missing


From: Paul Eggert
Subject: [Emacs-diffs] master b5376e0 2/2: Skip tests if test subdir is missing
Date: Fri, 3 May 2019 17:55:14 -0400 (EDT)

branch: master
commit b5376e0ebd7b62f00c1b64aef87cd8d96cfbc71a
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Skip tests if test subdir is missing
    
    Problem reported by Jeffrey Walton in:
    https://lists.gnu.org/r/emacs-devel/2019-05/msg00041.html
    * Makefile.in (CHECK_TARGETS): New macro; use it
    to simplify 'check' and similar rules.
    ($(CHECK_TARGETS)): If tests are missing, do not fail
    after issuing a diagnostic.  Just skip the tests.
---
 Makefile.in | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 06da415..21362a9 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -950,17 +950,15 @@ extraclean: $(extraclean_dirs:=_extraclean)
 TAGS tags: lib lib-src # src
        $(MAKE) -C src tags
 
-.PHONY: have-tests
-have-tests:
-       @if test ! -d test; then \
-         echo "You do not seem to have the test/ directory."; \
-         echo "Maybe you are using a release tarfile, rather than a repository 
checkout."; \
-        exit 1; \
-       fi
-
-.PHONY: check check-maybe check-expensive check-all
-check check-maybe check-expensive check-all: have-tests all
+CHECK_TARGETS = check check-maybe check-expensive check-all
+.PHONY: $(CHECK_TARGETS)
+$(CHECK_TARGETS): all
+ifeq ($(wildcard test),test)
        $(MAKE) -C test $@
+else
+       @echo "You do not seem to have the test/ directory."
+       @echo "Maybe you used a release tarfile that lacks tests."
+endif
 
 dist:
        cd ${srcdir}; ./make-dist



reply via email to

[Prev in Thread] Current Thread [Next in Thread]