[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] fill_column_indicator 2a17fae 8/9: display-fill-column-ind
From: |
Jimmy Aguilar Mena |
Subject: |
[Emacs-diffs] fill_column_indicator 2a17fae 8/9: display-fill-column-indicator.el condition |
Date: |
Wed, 1 May 2019 12:09:37 -0400 (EDT) |
branch: fill_column_indicator
commit 2a17fae672c0fffea282c04748de36d0b82a3099
Author: Jimmy Aguilar Mena <address@hidden>
Commit: Jimmy Aguilar Mena <address@hidden>
display-fill-column-indicator.el condition
*lisp/display-fill-column-indicator.el: Extended condition to set
display-fill-column-indicator-character in graphical displays.
*src/xdisp.c: Fixed some long lines.
---
lisp/display-fill-column-indicator.el | 5 ++-
src/xdisp.c | 62 ++++++++++++++++++++---------------
2 files changed, 40 insertions(+), 27 deletions(-)
diff --git a/lisp/display-fill-column-indicator.el
b/lisp/display-fill-column-indicator.el
index fa14879..f6b7352 100644
--- a/lisp/display-fill-column-indicator.el
+++ b/lisp/display-fill-column-indicator.el
@@ -55,7 +55,10 @@ character for the indicator setting
`display-fill-column-indicator-character'."
(progn
(setq display-fill-column-indicator t)
(unless display-fill-column-indicator-character
- (if (char-displayable-p ?\u2502)
+ (if (and (char-displayable-p ?\u2502)
+ (or (not (display-graphic-p))
+ (eq (aref (query-font (car (internal-char-font nil
?\u2502))) 0)
+ (face-font 'default))))
(setq display-fill-column-indicator-character ?\u2502)
(setq display-fill-column-indicator-character ?|))))
(setq display-fill-column-indicator nil)))
diff --git a/src/xdisp.c b/src/xdisp.c
index 31099e4..7537660 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -20177,19 +20177,23 @@ append_space_for_newline (struct it *it, bool
default_face_p)
XFIXNAT (Vdisplay_fill_column_indicator_column);
struct font *font =
- default_face->font ? default_face->font : FRAME_FONT (it->f);
+ default_face->font ?
+ default_face->font : FRAME_FONT (it->f);
const int char_width =
- font->average_width ? font->average_width : font->space_width;
+ font->average_width ?
+ font->average_width : font->space_width;
const int column_x =
- char_width * fill_column_indicator_column +
it->lnum_pixel_width;
+ char_width * fill_column_indicator_column +
+ it->lnum_pixel_width;
if (it->current_x == column_x)
{
it->c = it->char_to_display =
XFIXNAT (Vdisplay_fill_column_indicator_character);
it->face_id =
- merge_faces (it->w, Qfill_column_face, 0, DEFAULT_FACE_ID);
+ merge_faces (it->w, Qfill_column_face,
+ 0, DEFAULT_FACE_ID);
face = FACE_FROM_ID(it->f, it->face_id);
goto produce_glyphs;
}
@@ -20438,10 +20442,12 @@ extend_face_to_end_of_line (struct it *it)
struct font *font =
default_face->font ? default_face->font : FRAME_FONT (f);
const int char_width =
- font->average_width ? font->average_width : font->space_width;
+ font->average_width ?
+ font->average_width : font->space_width;
- const int column_x = char_width * fill_column_indicator_column +
- it->lnum_pixel_width;
+ const int column_x =
+ char_width * fill_column_indicator_column +
+ it->lnum_pixel_width;
if ((it->current_x <= column_x)
&& (column_x <= it->last_visible_x))
@@ -20453,39 +20459,43 @@ extend_face_to_end_of_line (struct it *it)
const bool saved_box_start = it->start_of_box_run_p;
Lisp_Object save_object = it->object;
- /* The stretch width needs to considet the latter added glyph
*/
- const int stretch_width = column_x - it->current_x -
char_width;
+ /* The stretch width needs to considet the latter
+ added glyph */
+ const int stretch_width =
+ column_x - it->current_x - char_width;
memset (&it->position, 0, sizeof it->position);
it->avoid_cursor_p = true;
it->object = Qnil;
- /* Only generate a stretch glysph if there is distance between
- current_x and and the indicator position */
+ /* Only generate a stretch glysph if there is distance
+ between current_x and and the indicator position */
if (stretch_width > 0)
- {
- int stretch_ascent = (((it->ascent + it->descent)
- * FONT_BASE (font)) / FONT_HEIGHT (font));
- append_stretch_glyph (it, Qnil, stretch_width,
- it->ascent + it->descent,
stretch_ascent);
- }
-
- /* Generate the glysph indicator only if
append_space_for_newline
- didn't already. */
+ {
+ int stretch_ascent = (((it->ascent + it->descent)
+ * FONT_BASE (font)) / FONT_HEIGHT
(font));
+ append_stretch_glyph (it, Qnil, stretch_width,
+ it->ascent + it->descent,
+ stretch_ascent);
+ }
+
+ /* Generate the glysph indicator only if
+ append_space_for_newline didn't already. */
if (it->current_x < column_x)
{
- it->char_to_display =
+ it->char_to_display =
XFIXNAT (Vdisplay_fill_column_indicator_character);
it->face_id =
- merge_faces (it->w, Qfill_column_face, 0,
DEFAULT_FACE_ID);
+ merge_faces (it->w, Qfill_column_face,
+ 0, DEFAULT_FACE_ID);
PRODUCE_GLYPHS (it);
}
/* Restore the face after the indicator was generated */
it->face_id = saved_face_id;
- /* If there is space after the indicator generate an extra
- empty glysph to restore the face. */
+ /* If there is space after the indicator generate an
+ extra empty glysph to restore the face. */
it->char_to_display = ' ';
PRODUCE_GLYPHS (it);
@@ -20624,8 +20634,8 @@ extend_face_to_end_of_line (struct it *it)
{
int fill_column_indicator_column = -1;
- /* Vdisplay_fill_column_indicator_column accepts the special value t
- to use the default fill-column variable. */
+ /* Vdisplay_fill_column_indicator_column accepts the special
+ value t to use the default fill-column variable. */
if (EQ (Vdisplay_fill_column_indicator_column, Qt)
&& FIXNATP (BVAR (current_buffer, fill_column)))
fill_column_indicator_column =
- [Emacs-diffs] branch fill_column_indicator created (now 650d842), Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator abc186b 4/9: Added fill-column-indicator manual documentation, Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator 8ee1093 3/9: Fixed fill-column-indicator for continuation lines, Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator f8397af 1/9: display-fill-column-indicator-mode implementation., Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator 2cbef4a 2/9: Display-fill-column-indicator NEWS and t value for column value, Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator 650d842 9/9: *src/xdisp.c: Fixed fill column indicator position in terminal mode., Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator 2a34024 5/9: Added correction in the texinfo manual., Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator da8b623 6/9: Small changes in the documentation, Jimmy Aguilar Mena, 2019/05/01
- [Emacs-diffs] fill_column_indicator 2a17fae 8/9: display-fill-column-indicator.el condition,
Jimmy Aguilar Mena <=
- [Emacs-diffs] fill_column_indicator 780f1ef 7/9: display-fill-column-indicator interface corrections, Jimmy Aguilar Mena, 2019/05/01