emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 3ec05e1: * lisp/net/tramp-adb.el (tramp-adb-handle-


From: Michael Albinus
Subject: [Emacs-diffs] master 3ec05e1: * lisp/net/tramp-adb.el (tramp-adb-handle-make-process):
Date: Tue, 12 Mar 2019 14:40:22 -0400 (EDT)

branch: master
commit 3ec05e1c3b4c46cf48e7039175d96596dd4b94be
Author: Michael Albinus <address@hidden>
Commit: Michael Albinus <address@hidden>

    * lisp/net/tramp-adb.el (tramp-adb-handle-make-process):
    
    Use proper range when deleting the region.
---
 lisp/net/tramp-adb.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/net/tramp-adb.el b/lisp/net/tramp-adb.el
index 33ff4cc..632ad12 100644
--- a/lisp/net/tramp-adb.el
+++ b/lisp/net/tramp-adb.el
@@ -1011,7 +1011,7 @@ PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are 
completely ignored."
                      ;; order to cleanup the prompt afterwards.
                      (tramp-adb-maybe-open-connection v)
                      (widen)
-                     (delete-region mark (point))
+                     (delete-region mark (point-max))
                      (narrow-to-region (point-max) (point-max))
                      ;; Send the command.
                      (let* ((p (tramp-get-connection-process v))
@@ -1127,12 +1127,14 @@ This happens for Android >= 4.0."
   (tramp-adb-maybe-open-connection vec)
   (tramp-message vec 6 "%s" command)
   (tramp-send-string vec command)
-  ;; fixme: Race condition
+  ;; FIXME: Race condition.
   (tramp-adb-wait-for-output (tramp-get-connection-process vec))
   (with-current-buffer (tramp-get-connection-buffer vec)
     (save-excursion
       (goto-char (point-min))
-      ;; We can't use stty to disable echo of command.
+      ;; We can't use stty to disable echo of command.  stty is said
+      ;; to be added to toybox 0.7.6.  busybox shall have it, but this
+      ;; isn't used any longer for Android.
       (delete-matching-lines (regexp-quote command))
       ;; When the local machine is W32, there are still trailing ^M.
       ;; There must be a better solution by setting the correct coding



reply via email to

[Prev in Thread] Current Thread [Next in Thread]