[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches
From: |
Pip Cet |
Subject: |
Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches |
Date: |
Wed, 22 Aug 2018 12:36:41 +0000 |
On Tue, Aug 21, 2018 at 9:01 PM Paul Eggert <address@hidden> wrote:
> * lisp/vc/vc-hg.el (vc-hg-state-fast): When testing fixnum width,
> prefer (zerop (ash most-positive-fixnum -32)) to (zerop (lsh -1
> 32)) (Bug#32485#11).
I think the previous code was correct: now we have bignums, we should
no longer return 'unsupported on machines with 30/32-bit fixnums,
because 32 bits fit just fine into a bignum. Another
`most-positive-fixnum' we can eliminate!
All appearances of "fixnum" in that file should be replaced by "integer".