emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 57c4bc1: 0x%x → %#x in elisp formats


From: Paul Eggert
Subject: [Emacs-diffs] master 57c4bc1: 0x%x → %#x in elisp formats
Date: Mon, 23 Jul 2018 04:10:13 -0400 (EDT)

branch: master
commit 57c4bc146b7e17b6f662604047cb5d10982f962c
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    0x%x → %#x in elisp formats
    
    * lisp/emacs-lisp/cl-print.el (cl-print-object):
    * lisp/profiler.el (profiler-format-entry):
    * lisp/progmodes/hideif.el (hif-evaluate-macro):
    Prefer %#x to 0x%x in elisp formats when formatting arbitrary
    integers, as it’ll produce more-readable output with negative args
    should we change how negative values are printed with %x.
---
 lisp/emacs-lisp/cl-print.el | 4 ++--
 lisp/profiler.el            | 6 +++---
 lisp/progmodes/hideif.el    | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/emacs-lisp/cl-print.el b/lisp/emacs-lisp/cl-print.el
index 1eae8fa..bf5b1e8 100644
--- a/lisp/emacs-lisp/cl-print.el
+++ b/lisp/emacs-lisp/cl-print.el
@@ -109,7 +109,7 @@ call other entry points instead, such as `cl-prin1'."
   (princ (hash-table-count object) stream)
   (princ "/" stream)
   (princ (hash-table-size object) stream)
-  (princ (format " 0x%x" (sxhash object)) stream)
+  (princ (format " %#x" (sxhash object)) stream)
   (princ ">" stream))
 
 (define-button-type 'help-byte-code
@@ -166,7 +166,7 @@ into a button whose action shows the function's 
disassembly.")
     (let ((button-start (and cl-print-compiled-button
                              (bufferp stream)
                              (with-current-buffer stream (point)))))
-      (princ (format "#<bytecode 0x%x>" (sxhash object)) stream)
+      (princ (format "#<bytecode %#x>" (sxhash object)) stream)
       (when (eq cl-print-compiled 'static)
         (princ " " stream)
         (cl-print-object (aref object 2) stream))
diff --git a/lisp/profiler.el b/lisp/profiler.el
index eaeb697..41dea68 100644
--- a/lisp/profiler.el
+++ b/lisp/profiler.el
@@ -105,13 +105,13 @@
   "Format ENTRY in human readable string.  ENTRY would be a
 function name of a function itself."
   (cond ((memq (car-safe entry) '(closure lambda))
-        (format "#<lambda 0x%x>" (sxhash entry)))
+        (format "#<lambda %#x>" (sxhash entry)))
        ((byte-code-function-p entry)
-        (format "#<compiled 0x%x>" (sxhash entry)))
+        (format "#<compiled %#x>" (sxhash entry)))
        ((or (subrp entry) (symbolp entry) (stringp entry))
         (format "%s" entry))
        (t
-        (format "#<unknown 0x%x>" (sxhash entry)))))
+        (format "#<unknown %#x>" (sxhash entry)))))
 
 (defun profiler-fixup-entry (entry)
   (if (symbolp entry)
diff --git a/lisp/progmodes/hideif.el b/lisp/progmodes/hideif.el
index ce7127a..24ad2ff 100644
--- a/lisp/progmodes/hideif.el
+++ b/lisp/progmodes/hideif.el
@@ -1625,7 +1625,7 @@ not be expanded."
          ((integerp result)
           (if (or (= 0 result) (= 1 result))
               (message "%S <= `%s'" result exprstring)
-            (message "%S (0x%x) <= `%s'" result result exprstring)))
+            (message "%S (%#x) <= `%s'" result result exprstring)))
          ((null result) (message "%S <= `%s'" 'false exprstring))
          ((eq t result) (message "%S <= `%s'" 'true exprstring))
          (t (message "%S <= `%s'" result exprstring)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]