emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master bc85cdc 1/2: Suppress some compiler warnings about


From: Glenn Morris
Subject: [Emacs-diffs] master bc85cdc 1/2: Suppress some compiler warnings about pcomplete
Date: Mon, 5 Mar 2018 14:29:53 -0500 (EST)

branch: master
commit bc85cdc16946ad2592450dd6b6ebc42be6421b05
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>

    Suppress some compiler warnings about pcomplete
    
    * lisp/erc/erc-dcc.el, lisp/eshell/em-xtra.el:
    Load pcomplete at run-time too, to silence compiler.
---
 lisp/erc/erc-dcc.el    | 4 +++-
 lisp/eshell/em-xtra.el | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/lisp/erc/erc-dcc.el b/lisp/erc/erc-dcc.el
index 764c6cc..5bc8c2f 100644
--- a/lisp/erc/erc-dcc.el
+++ b/lisp/erc/erc-dcc.el
@@ -54,7 +54,9 @@
 ;;; Code:
 
 (require 'erc)
-(eval-when-compile (require 'pcomplete))
+;; Strictly speaking, should only be needed at compile time.
+;; Require at run-time too to silence compiler.
+(require 'pcomplete)
 
 ;;;###autoload(autoload 'erc-dcc-mode "erc-dcc")
 (define-erc-module dcc nil
diff --git a/lisp/eshell/em-xtra.el b/lisp/eshell/em-xtra.el
index ce73474..cc84d19 100644
--- a/lisp/eshell/em-xtra.el
+++ b/lisp/eshell/em-xtra.el
@@ -25,8 +25,10 @@
 
 (require 'esh-util)
 (eval-when-compile
-  (require 'eshell)
-  (require 'pcomplete))
+  (require 'eshell))
+;; Strictly speaking, should only be needed at compile time.
+;; Require at run-time too to silence compiler.
+(require 'pcomplete)
 (require 'compile)
 
 ;; There are no items in this custom group, but eshell modules (ab)use



reply via email to

[Prev in Thread] Current Thread [Next in Thread]