[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] scratch/eudc-bbdb-3 f529b7d 07/15: EUDC: Fix issues report
From: |
Thomas Fitzsimmons |
Subject: |
[Emacs-diffs] scratch/eudc-bbdb-3 f529b7d 07/15: EUDC: Fix issues reported by checkdoc |
Date: |
Tue, 21 Nov 2017 23:47:51 -0500 (EST) |
branch: scratch/eudc-bbdb-3
commit f529b7df507ba1e4eef90d2b85ce2a8fd8e77d96
Author: Thomas Fitzsimmons <address@hidden>
Commit: Thomas Fitzsimmons <address@hidden>
EUDC: Fix issues reported by checkdoc
* lisp/net/eudcb-bbdb.el: Fix issues reported by checkdoc.
---
lisp/net/eudcb-bbdb.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/net/eudcb-bbdb.el b/lisp/net/eudcb-bbdb.el
index d606766..f7011a2 100644
--- a/lisp/net/eudcb-bbdb.el
+++ b/lisp/net/eudcb-bbdb.el
@@ -66,7 +66,7 @@ BBDB < 3 used `net'; BBDB >= 3 uses `mail'."
(eudc-protocol-set 'eudc-protocol-has-default-query-attributes nil 'bbdb)
(defun eudc-bbdb-format-query (query)
- "Format a EUDC query alist into a list suitable to `bbdb-search'."
+ "Format QUERY, an EUDC alist, into a list suitable to `bbdb-search'."
(let* ((firstname (cdr (assq 'firstname query)))
(lastname (cdr (assq 'lastname query)))
(name (or (and firstname lastname
@@ -81,7 +81,7 @@ BBDB < 3 used `net'; BBDB >= 3 uses `mail'."
(defun eudc-bbdb-filter-non-matching-record (record)
- "Return RECORD if it matches `eudc-bbdb-current-query', nil otherwise."
+ "Return RECORD if it is a match for `eudc-bbdb-current-query', nil
otherwise."
(require 'bbdb)
(catch 'unmatch
(progn
@@ -126,6 +126,7 @@ BBDB < 3 used `net'; BBDB >= 3 uses `mail'."
(&optional dont-check-disk already-in-db-buffer))
(defun eudc-bbdb-extract-phones (record)
+ "Extract phone numbers from BBDB RECORD."
(require 'bbdb)
;; Keep same order as in BBDB record.
(nreverse
@@ -140,6 +141,7 @@ BBDB < 3 used `net'; BBDB >= 3 uses `mail'."
(bbdb-record-phones record))))
(defun eudc-bbdb-extract-addresses (record)
+ "Extract addresses from BBDB RECORD."
(require 'bbdb)
(let (s c val)
(nreverse
@@ -249,7 +251,9 @@ RETURN-ATTRS is a list of attributes to return, defaulting
to
;;{{{ High-level interfaces (interactive functions)
(defun eudc-bbdb-set-server (dummy)
- "Set the EUDC server to BBDB."
+ "Set the EUDC server to BBDB.
+Take a DUMMY argument to match other EUDC backend set-server
+functions."
(interactive)
(eudc-set-server dummy 'bbdb)
(message "BBDB server selected"))
- [Emacs-diffs] branch scratch/eudc-bbdb-3 created (now 69e8cb9), Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 c6c1286 02/15: EUDC: Fix indentation in BBDB backend, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 3636aa2 03/15: EUDC: Fix whitespace in BBDB backend, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 5e6c763 14/15: EUDC: Wrap long lines in eudc-export.el, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 e02938d 11/15: EUDC: Obsolete eudc--using-bbdb-3-or-newer-p, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 06c3557 08/15: EUDC: Require bbdb and bbdb-com without ignoring errors, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 2beb511 04/15: EUDC: Wrap long line in BBDB backend, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 f529b7d 07/15: EUDC: Fix issues reported by checkdoc,
Thomas Fitzsimmons <=
- [Emacs-diffs] scratch/eudc-bbdb-3 262dce0 09/15: EUDC: Remove external BBDB function declarations, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 69e8cb9 15/15: EUDC: Port eudc-export.el to BBDB >= 3, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 f1ab95d 12/15: EUDC: Require bbdb, bbdb-com without NOERROR, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 c80692b 05/15: EUDC: Keep phone and address lists in BBDB-order, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 05257b9 10/15: EUDC: Port BBDB backend to BBDB >= 3, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 6e680a7 06/15: EUDC: Print multiple BBDB addresses properly, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 eaf20ca 13/15: EUDC: Fix whitespace in eudc-export.el, Thomas Fitzsimmons, 2017/11/21
- [Emacs-diffs] scratch/eudc-bbdb-3 9bfbbd4 01/15: BBDB: Import BBDB 3, Thomas Fitzsimmons, 2017/11/21