emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 237e96b: Test that advice doesn't trigger bytecom


From: Noam Postavsky
Subject: [Emacs-diffs] emacs-26 237e96b: Test that advice doesn't trigger bytecomp warnings (Bug#28803)
Date: Sat, 21 Oct 2017 19:31:20 -0400 (EDT)

branch: emacs-26
commit 237e96bc5259e59ac5623a93a47f64abffab4e0b
Author: John Williams <address@hidden>
Commit: Noam Postavsky <address@hidden>

    Test that advice doesn't trigger bytecomp warnings (Bug#28803)
    
    * test/lisp/emacs-lisp/bytecomp-tests.el
    (bytecomp-tests--test-no-warnings-with-advice): New test.
    
    Copyright-paperwork-exempt: yes
---
 test/lisp/emacs-lisp/bytecomp-tests.el | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el 
b/test/lisp/emacs-lisp/bytecomp-tests.el
index 30d2a47..f508c36 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -564,6 +564,17 @@ and will be removed soon.  See (elisp)Backquote in the 
manual.")))))))
     (byte-compile-file source t)
     (should (equal bytecomp-tests--foobar (cons 1 2)))))
 
+(ert-deftest bytecomp-tests--test-no-warnings-with-advice ()
+  (defun f ())
+  (define-advice f (:around (oldfun &rest args) test)
+    (apply oldfun args))
+  (with-current-buffer (get-buffer-create "*Compile-Log*")
+    (let ((inhibit-read-only t)) (erase-buffer)))
+  (test-byte-comp-compile-and-load t '(defun f ()))
+  (with-current-buffer (get-buffer-create "*Compile-Log*")
+    (goto-char (point-min))
+    (should-not (search-forward "Warning" nil t))))
+
 ;; Local Variables:
 ;; no-byte-compile: t
 ;; End:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]