emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 db68cef: Fix errors in kmacro.el post-command-hoo


From: Eli Zaretskii
Subject: [Emacs-diffs] emacs-26 db68cef: Fix errors in kmacro.el post-command-hook
Date: Mon, 16 Oct 2017 12:37:17 -0400 (EDT)

branch: emacs-26
commit db68cefe72e5c68fa81796028a52de1b8e6480aa
Author: Eli Zaretskii <address@hidden>
Commit: Eli Zaretskii <address@hidden>

    Fix errors in kmacro.el post-command-hook
    
    * lisp/kmacro.el (kmacro-step-edit-active): Initialize to nil to
    avoid 'void-variable' errors.  (Bug#28818)
    * test/lisp/kmacro-tests.el
    (kmacro-tests-step-edit-cleans-up-hook): Now succeeds.  (Bug#18708)
---
 lisp/kmacro.el            | 2 +-
 test/lisp/kmacro-tests.el | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/kmacro.el b/lisp/kmacro.el
index 582a58e..4abc571 100644
--- a/lisp/kmacro.el
+++ b/lisp/kmacro.el
@@ -937,7 +937,7 @@ without repeating the prefix."
 
 ;;; Single-step editing of keyboard macros
 
-(defvar kmacro-step-edit-active)        ;; step-editing active
+(defvar kmacro-step-edit-active nil)    ;; step-editing active
 (defvar kmacro-step-edit-new-macro)     ;; storage for new macro
 (defvar kmacro-step-edit-inserting)     ;; inserting into macro
 (defvar kmacro-step-edit-appending)     ;; append to end of macro
diff --git a/test/lisp/kmacro-tests.el b/test/lisp/kmacro-tests.el
index 9f3eeaf..690d502 100644
--- a/test/lisp/kmacro-tests.el
+++ b/test/lisp/kmacro-tests.el
@@ -818,7 +818,6 @@ This is a regression for item 7 in Bug#24991."
 
 (kmacro-tests-deftest kmacro-tests-step-edit-cleans-up-hook ()
   "Step-editing properly cleans up `post-command-hook.' (Bug #18708)"
-  (:expected-result :failed)
   (let (post-command-hook)
     (setq-local post-command-hook '(t))
     (kmacro-tests-run-step-edit "x"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]