[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-26 cd39edb 26/39: Remove old flymake-display-err-men
From: |
João Távora |
Subject: |
[Emacs-diffs] emacs-26 cd39edb 26/39: Remove old flymake-display-err-menu-for-current-line, it's useless |
Date: |
Tue, 3 Oct 2017 10:04:52 -0400 (EDT) |
branch: emacs-26
commit cd39edb5d641f82accad21cd85ff26b3995f1c85
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Remove old flymake-display-err-menu-for-current-line, it's useless
See https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00949.html
* lisp/progmodes/flymake-ui.el
(flymake-popup-current-error-menu): Remove.
---
lisp/progmodes/flymake.el | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 0071ba9..20c94d2 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -467,38 +467,6 @@ associated `flymake-category' return DEFAULT."
(flymake-log :debug "starting syntax check after no changes for some
time")
(flymake-start)))))
-(define-obsolete-function-alias 'flymake-display-err-menu-for-current-line
- 'flymake-popup-current-error-menu "24.4")
-
-(defun flymake-popup-current-error-menu (&optional event)
- "Pop up a menu with errors/warnings for current line."
- (interactive (list last-nonmenu-event))
- (let* ((diag-overlays (or
- (flymake--overlays :filter 'flymake--diagnostic
- :beg (line-beginning-position)
- :end (line-end-position))
- (user-error "No flymake problem for current line")))
- (menu (mapcar (lambda (ov)
- (let ((diag (overlay-get ov 'flymake--diagnostic)))
- (cons (flymake--diag-text diag)
- ov)))
- diag-overlays))
- (event (if (mouse-event-p event)
- event
- (list 'mouse-1 (posn-at-point))))
- (diagnostics (mapcar (lambda (ov) (overlay-get ov
'flymake--diagnostic))
- diag-overlays))
- (title (format "Line %d: %d diagnostics(s)"
- (line-number-at-pos)
- (length diagnostics)))
- (choice (x-popup-menu event (list title (cons "" menu)))))
- (flymake-log :debug "choice=%s" choice)
- ;; FIXME: What is the point of going to the problem locus if we're
- ;; certainly already there?
- ;;
- (when choice (goto-char (overlay-start choice)))))
-
-
;; Nothing in flymake uses this at all any more, so this is just for
;; third-party compatibility.
(define-obsolete-function-alias 'flymake-display-warning 'message-box "26.1")
- [Emacs-diffs] emacs-26 9a629a7 23/39: Add interactive flymake-start function, (continued)
- [Emacs-diffs] emacs-26 9a629a7 23/39: Add interactive flymake-start function, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 b0bb181 15/39: Protect Flymake's eager checks against commands like fill-paragraph, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 b2f8b8b 16/39: More Flymake cleanup before advancing to backend redesign, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 22a7372 31/39: Flymake uses proper idle timers, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 87993cd 28/39: Explicitly add a(n empty) keymap for Flymake, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 bb8b663 04/39: Move symbols in flymake-proc.el to separate namespace, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 483f1e8 22/39: A couple of Flymake backends for emacs-lisp-mode, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5235eaf 25/39: Treat Flymake errors as just another type of diagnostic, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 8118f0f 24/39: Fix three Flymake bugs when checking C header files, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 e0df7b9 21/39: Fancy Flymake mode-line construct displays status, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 cd39edb 26/39: Remove old flymake-display-err-menu-for-current-line, it's useless,
João Távora <=
- [Emacs-diffs] emacs-26 2e84179 34/39: Tweak Flymake autoloads and dependencies, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 7360178 20/39: Tweak Flymake commands flymake-goto-[next/prev]-error, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 1b271ad 27/39: Flymake uses some new fringe bitmaps, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 94a88c1 17/39: New Flymake API variable flymake-diagnostic-functions, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5d922e5 38/39: Start rewriting Flymake manual, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 fe9dc7a 01/39: Split Flymake into flymake.el into flymake-proc.el (again!), João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 30ea272 35/39: Hook Flymake onto proper checkdoc and byte-compile interfaces, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 5d3f8a8 33/39: Capitalize "Flymake" in docstrings and comments, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 bd8ea88 29/39: Batch of minor Flymake cleanup actions agreed to with Stefan, João Távora, 2017/10/03
- [Emacs-diffs] emacs-26 91851c3 30/39: Flymake variable flymake-diagnostic-functions now a special hook, João Távora, 2017/10/03