emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] scratch/flymake-refactor-cleaner-for-emacs-26 555bea3 11/3


From: João Távora
Subject: [Emacs-diffs] scratch/flymake-refactor-cleaner-for-emacs-26 555bea3 11/39: Protect against timer triggers when no flymake-mode
Date: Mon, 2 Oct 2017 20:12:22 -0400 (EDT)

branch: scratch/flymake-refactor-cleaner-for-emacs-26
commit 555bea3615c2fb032c2b24ff6252e4322e9192d0
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Protect against timer triggers when no flymake-mode
    
    Not 100% sure on how to trigger this error, but it happened once or
    twice, possibly during heavy debugging scenarios that wouldn't really
    happen.  But a good idea anyway.
    
    * lisp/progmodes/flymake.el (flymake-on-timer-event): Check flymake-mode
---
 lisp/progmodes/flymake.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e8d5de6..7968070 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -361,7 +361,8 @@ return DEFAULT."
   "Start a syntax check for buffer BUFFER if necessary."
   (when (buffer-live-p buffer)
     (with-current-buffer buffer
-      (when (and (not flymake-is-running)
+      (when (and flymake-mode
+                 (not flymake-is-running)
                 flymake-last-change-time
                 (> (- (float-time) flymake-last-change-time)
                     flymake-no-changes-timeout))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]