[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] scratch/flymake-refactor 38c7d4f 4/6: Remove old flymake-d
From: |
João Távora |
Subject: |
[Emacs-diffs] scratch/flymake-refactor 38c7d4f 4/6: Remove old flymake-display-err-menu-for-current-line, it's useless |
Date: |
Thu, 28 Sep 2017 10:28:23 -0400 (EDT) |
branch: scratch/flymake-refactor
commit 38c7d4f3bff8de3b2a54467ccfd875f4091033f9
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Remove old flymake-display-err-menu-for-current-line, it's useless
See https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00949.html
* lisp/progmodes/flymake-ui.el
(flymake-popup-current-error-menu): Remove.
---
lisp/progmodes/flymake-ui.el | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/lisp/progmodes/flymake-ui.el b/lisp/progmodes/flymake-ui.el
index 2cbb749..14c5d02 100644
--- a/lisp/progmodes/flymake-ui.el
+++ b/lisp/progmodes/flymake-ui.el
@@ -441,38 +441,6 @@ return DEFAULT."
(flymake-log 3 "starting syntax check as more than 1 second passed
since last change")
(flymake-start)))))
-(define-obsolete-function-alias 'flymake-display-err-menu-for-current-line
- 'flymake-popup-current-error-menu "24.4")
-
-(defun flymake-popup-current-error-menu (&optional event)
- "Pop up a menu with errors/warnings for current line."
- (interactive (list last-nonmenu-event))
- (let* ((diag-overlays (or
- (flymake--overlays :filter 'flymake--diagnostic
- :beg (line-beginning-position)
- :end (line-end-position))
- (user-error "No flymake problem for current line")))
- (menu (mapcar (lambda (ov)
- (let ((diag (overlay-get ov 'flymake--diagnostic)))
- (cons (flymake--diag-text diag)
- ov)))
- diag-overlays))
- (event (if (mouse-event-p event)
- event
- (list 'mouse-1 (posn-at-point))))
- (diagnostics (mapcar (lambda (ov) (overlay-get ov
'flymake--diagnostic))
- diag-overlays))
- (title (format "Line %d: %d diagnostics(s)"
- (line-number-at-pos)
- (length diagnostics)))
- (choice (x-popup-menu event (list title (cons "" menu)))))
- (flymake-log 3 "choice=%s" choice)
- ;; FIXME: What is the point of going to the problem locus if we're
- ;; certainly already there?
- ;;
- (when choice (goto-char (overlay-start choice)))))
-
-
;; Nothing in flymake uses this at all any more, so this is just for
;; third-party compatibility.
(define-obsolete-function-alias 'flymake-display-warning 'message-box "26.1")
- [Emacs-diffs] scratch/flymake-refactor updated (3b6c736 -> 1116aa7), João Távora, 2017/09/28
- [Emacs-diffs] scratch/flymake-refactor 1d58e32 2/6: Fix flymake-wrap-around for buffers with no errors, João Távora, 2017/09/28
- [Emacs-diffs] scratch/flymake-refactor 9d93d46 5/6: New flymake fringe bitmaps, João Távora, 2017/09/28
- [Emacs-diffs] scratch/flymake-refactor 1116aa7 6/6: * lisp/progmodes/flymake-ui.el (flymake-mode-map): Bind "M-n" and "M-p", João Távora, 2017/09/28
- [Emacs-diffs] scratch/flymake-refactor 38c7d4f 4/6: Remove old flymake-display-err-menu-for-current-line, it's useless,
João Távora <=
- [Emacs-diffs] scratch/flymake-refactor 7d3d3d3 1/6: Fix flymake problems when checking C header files, João Távora, 2017/09/28
- [Emacs-diffs] scratch/flymake-refactor 9329265 3/6: Treat flymake errors as just another type of diagnostic, João Távora, 2017/09/28