emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 255f675: Convert some network test failures to skip


From: Glenn Morris
Subject: [Emacs-diffs] master 255f675: Convert some network test failures to skipping
Date: Wed, 11 Jan 2017 19:36:05 +0000 (UTC)

branch: master
commit 255f675d890b7fa2dc97a40dc03e82fa95b22e65
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>

    Convert some network test failures to skipping
    
    These tests intermittently fail on hydra.nixos.org for unclear
    reasons related to starting the external process.
    This isn't an Emacs issue, and the failures cause noise on
    the emacs-buildstatus list.  (Bug#24503)
    * test/lisp/net/network-stream-tests.el (echo-server-nowait)
    (connect-to-tls-ipv4-nowait): Skip rather than fail if the
    external process fails to start properly.
---
 test/lisp/net/network-stream-tests.el |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/lisp/net/network-stream-tests.el 
b/test/lisp/net/network-stream-tests.el
index b237fea..e7bb3e8 100644
--- a/test/lisp/net/network-stream-tests.el
+++ b/test/lisp/net/network-stream-tests.el
@@ -152,7 +152,7 @@
     (while (and (eq (process-status proc) 'connect)
                 (< (setq times (1+ times)) 10))
       (sit-for 0.1))
-    (should-not (eq (process-status proc) 'connect))
+    (skip-unless (not (eq (process-status proc) 'connect)))
     (with-current-buffer (process-buffer proc)
       (process-send-string proc "echo foo")
       (sleep-for 0.1)
@@ -240,7 +240,7 @@
           (while (and (eq (process-status proc) 'connect)
                       (< (setq times (1+ times)) 10))
             (sit-for 0.1))
-          (should-not (eq (process-status proc) 'connect)))
+          (skip-unless (not (eq (process-status proc) 'connect))))
       (if (process-live-p server) (delete-process server)))
     (setq status (gnutls-peer-status proc))
     (should (consp status))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]