[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master aacb20c 3/3: More small fixes for image-dired
From: |
Mark Oteiza |
Subject: |
[Emacs-diffs] master aacb20c 3/3: More small fixes for image-dired |
Date: |
Tue, 13 Dec 2016 16:50:04 +0000 (UTC) |
branch: master
commit aacb20c0b73dc34e53c268e39131332d779cfe35
Author: Mark Oteiza <address@hidden>
Commit: Mark Oteiza <address@hidden>
More small fixes for image-dired
* lisp/image-dired.el: Fix commentary to refer to correct Emacs manual
node.
(image-dired--with-db-file): Add declare forms.
(image-dired-hidden-p): Rewrite with cl-loop. It's not necessary to
run through the whole list.
---
lisp/image-dired.el | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 30705f8..c5fcadc 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -79,7 +79,7 @@
;;
;; This information has been moved to the manual. Type `C-h r' to open
;; the Emacs manual and go to the node Thumbnails by typing `g
-;; Thumbnails RET'.
+;; Image-Dired RET'.
;;
;; Quickstart: M-x image-dired RET DIRNAME RET
;;
@@ -516,6 +516,7 @@ before warning the user."
(defmacro image-dired--with-db-file (&rest body)
"Run BODY in a temp buffer containing `image-dired-db-file'.
Return the last form in BODY."
+ (declare (indent 0) (debug t))
`(with-temp-buffer
(if (file-exists-p image-dired-db-file)
(insert-file-contents image-dired-db-file))
@@ -2238,13 +2239,8 @@ image-dired-file-comment-list:
(defun image-dired-hidden-p (file)
"Return t if image FILE has a \"hidden\" tag."
- (let (hidden)
- (mapc
- (lambda (tag)
- (if (member tag image-dired-gallery-hidden-tags)
- (setq hidden t)))
- (cdr (assoc file image-dired-file-tag-list)))
- hidden))
+ (cl-loop for tag in (cdr (assoc file image-dired-file-tag-list))
+ if (member tag image-dired-gallery-hidden-tags) return t))
(defun image-dired-gallery-generate ()
"Generate gallery pages.