[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 a4d882c: Correct old cell name unbinding when
From: |
Nicolas Petton |
Subject: |
Re: [Emacs-diffs] emacs-25 a4d882c: Correct old cell name unbinding when renaming cell. |
Date: |
Sun, 24 Jul 2016 12:50:30 +0200 |
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) |
Vincent Belaïche <address@hidden> writes:
Hi Vincent,
> * ses.el (ses-rename-cell): check consistency of cell symbol from
> text-property and from array object. Instead of 'makunbound', use
> either 'ses--unbind-cell-name' or 'kill-local-variable' depending on
> whether the cell old name is a named cell or an A1 type cell
Please make sure to specify the full path of modified files in commit
messages, as they are later used in ChangeLog entries, which otherwise
have to be fixed manually.
In this case, it should have been:
* lisp/ses.el (ses-rename-cell): ...
If you're using Magit, it can insert changelog entries for the file at
point for you with `magit-add-changelog-entry'. If you use vc, you can
instead use `add-change-log-entry-other-window', bound to C-x 4 a.
Cheers,
Nico
signature.asc
Description: PGP signature
- Re: [Emacs-diffs] emacs-25 a4d882c: Correct old cell name unbinding when renaming cell.,
Nicolas Petton <=