emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-25 9356fe2: Expand FIXME near definition of fboundp


From: Noam Postavsky
Subject: [Emacs-diffs] emacs-25 9356fe2: Expand FIXME near definition of fboundp
Date: Sun, 17 Jul 2016 01:34:07 +0000 (UTC)

branch: emacs-25
commit 9356fe239281ca15e12a4e5e93d7d00c56df2626
Author: Robert Cochran <address@hidden>
Commit: Noam Postavsky <address@hidden>

    Expand FIXME near definition of fboundp
    
    This expansion of the FIXME is so that future developers are aware of
    the potential problems of aliasing fboundp to symbol-function without
    taking backwards compatibility into account.
    
    * src/data.c (fboundp): Note potential backwards compatibility issues in
    FIXME.
    
    Copyright-paperwork-exempt: yes
---
 src/data.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/data.c b/src/data.c
index 2574cbb..d14c84e 100644
--- a/src/data.c
+++ b/src/data.c
@@ -629,7 +629,12 @@ global value outside of any lexical scope.  */)
   return (EQ (valcontents, Qunbound) ? Qnil : Qt);
 }
 
-/* FIXME: Make it an alias for function-symbol!  */
+/* FIXME: It has been previously suggested to make this function an
+   alias for symbol-function, but upon discussion at Debbug#23957,
+   there is a risk breaking backward compatiblity, as some users of
+   fboundp may expect `t' in particular, rather than any true
+   value.  An alias is still welcome so long as the compatibility
+   issues are addressed.  */
 DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0,
        doc: /* Return t if SYMBOL's function definition is not void.  */)
   (register Lisp_Object symbol)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]