[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 2ede295: Prohibit multibyte characters in url-http-
From: |
Dmitry Gutov |
Subject: |
[Emacs-diffs] master 2ede295: Prohibit multibyte characters in url-http-data |
Date: |
Sun, 19 Jun 2016 18:08:35 +0000 (UTC) |
branch: master
commit 2ede29575fa22eb7c265117d7511cff9fe02c606
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>
Prohibit multibyte characters in url-http-data
It didn't work anyway, but this makes any such errors more obvious
by catching them earlier.
* lisp/url/url-http.el (url-http-create-request):
Use string-to-unibyte (bug#23750).
---
lisp/url/url-http.el | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 306b36a..0e6f5d3 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -310,14 +310,10 @@ The string is based on `url-privacy-level' and
`url-user-agent'."
;; We used to concat directly, but if one of the strings happens
;; to being multibyte (even if it only contains pure ASCII) then
;; every string gets converted with `string-MAKE-multibyte' which
- ;; turns the 127-255 codes into things like latin-1 accented chars
- ;; (it would work right if it used `string-TO-multibyte' instead).
+ ;; turns the 127-255 codes into things like latin-1 accented chars.
;; So to avoid the problem we force every string to be unibyte.
(mapconcat
- ;; FIXME: Instead of `string-AS-unibyte' we'd want
- ;; `string-to-unibyte', so as to properly signal an error if one
- ;; of the strings contains a multibyte char.
- 'string-as-unibyte
+ 'string-to-unibyte
(delq nil
(list
;; The request
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master 2ede295: Prohibit multibyte characters in url-http-data,
Dmitry Gutov <=