Re: [Emacs-diffs] emacs-25 a4d882c: Correct old cell name unbinding when renaming cell.

[Nicolas Petton]

Vincent Belaïche <address@hidden> writes:

Hi Vincent,

> branch: emacs-25
> commit a4d882cd09507fa1f891984fc7435923de3566fe
> Author: Vincent Belaïche <address@hidden>
> Commit: Vincent Belaïche <address@hidden>
>
>     Correct old cell name unbinding when renaming cell.
>     
>     Bug is to unbind old cell names when renaming a cell with
>     'makunbound'. when the old cell name is of A1 type, then
>     'kill-local-variable' must be used instead, so that only the current
>     spreadsheet is affected. When the old cell name is a renamed cell,
>     then 'ses--unbind-cell-name' must be used in order to remove the old
>     name from the name hashmap.
>     
>     * ses.el (ses-rename-cell): check consistency of cell symbol from
>     text-property and from array object. Instead of 'makunbound', use
>     either 'ses--unbind-cell-name' or 'kill-local-variable' depending on
>     whether the cell old name is a named cell or an A1 type cell

Please make sure to write valid log entries in commit messages, with the
full path to modified files (instead of their names).

Cheers,
Nico

signature.asc
Description: PGP signature