[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 487bd7a: Remove some useless-use-of eval.
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] master 487bd7a: Remove some useless-use-of eval. |
Date: |
Fri, 29 Jan 2016 02:16:21 +0000 |
branch: master
commit 487bd7aedf9bbbf0b939b653912253fbeb7d16b9
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>
Remove some useless-use-of eval.
* lisp/gnus/gnus.el (gnus-load-hook): Don't use eval.
* lisp/gnus/nnrss.el (xml): Simply require it.
(xml-rpc-method-call): Use declare-function.
---
lisp/gnus/gnus.el | 2 +-
lisp/gnus/nnrss.el | 10 ++++------
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el
index 5d2ce7e..996bb9e 100644
--- a/lisp/gnus/gnus.el
+++ b/lisp/gnus/gnus.el
@@ -27,7 +27,7 @@
;;; Code:
-(eval '(run-hooks 'gnus-load-hook))
+(run-hooks 'gnus-load-hook)
(eval-when-compile (require 'cl))
(require 'wid-edit)
diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el
index c17a13c..bef8203 100644
--- a/lisp/gnus/nnrss.el
+++ b/lisp/gnus/nnrss.el
@@ -37,10 +37,7 @@
(require 'mm-url)
(require 'rfc2047)
(require 'mml)
-(eval-when-compile
- (ignore-errors
- (require 'xml)))
-(eval '(require 'xml))
+(require 'xml)
(nnoo-declare nnrss)
@@ -372,8 +369,6 @@ for decoding when the cdr that the data specify is not
available.")
(nnoo-define-skeleton nnrss)
;;; Internal functions
-(eval-when-compile (defun xml-rpc-method-call (&rest args)))
-
(defun nnrss-get-encoding ()
"Return an encoding attribute specified in the current xml contents.
If `nnrss-compatible-encoding-alist' specifies the compatible encoding,
@@ -959,6 +954,9 @@ Use Mark Pilgrim's `ultra-liberal rss locator'."
;; 4. check syndic8
(nnrss-find-rss-via-syndic8 url))))))))
+(declare-function xml-rpc-method-call "ext:xml-rpc"
+ (server-url method &rest params))
+
(defun nnrss-find-rss-via-syndic8 (url)
"Query syndic8 for the rss feeds it has for URL."
(if (not (locate-library "xml-rpc"))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master 487bd7a: Remove some useless-use-of eval.,
Glenn Morris <=