[Emacs-diffs] trunk r118031: * lisp/erc/erc.el (erc-channel-receive-names): Silence compiler warning.

[Stefan Monnier]

------------------------------------------------------------
revno: 118031
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Fri 2014-10-03 23:04:51 -0400
message:
  * lisp/erc/erc.el (erc-channel-receive-names): Silence compiler warning.
  (address@hidden, erc-update-modes): Idem.
modified:
  lisp/erc/ChangeLog             changelog-20091113204419-o5vbwnq5f7feedwu-4305
  lisp/erc/erc.el                erc.el-20091113204419-o5vbwnq5f7feedwu-4346

=== modified file 'lisp/erc/ChangeLog'
--- a/lisp/erc/ChangeLog        2014-10-03 11:08:37 +0000
+++ b/lisp/erc/ChangeLog        2014-10-04 03:04:51 +0000
@@ -1,3 +1,8 @@
+2014-10-04  Stefan Monnier  <address@hidden>
+
+       * erc.el (erc-channel-receive-names): Silence compiler warning.
+       (address@hidden, erc-update-modes): Idem.
+
 2014-10-03  Kelvin White  <address@hidden>
 
        * erc.el (erc-rename-buffers): Use defcustom instead of defvar for

=== modified file 'lisp/erc/erc.el'
--- a/lisp/erc/erc.el   2014-10-03 11:08:37 +0000
+++ b/lisp/erc/erc.el   2014-10-04 03:04:51 +0000
@@ -4246,7 +4246,7 @@
            (erc-propertize "+" 'help-echo "voice"))
           (t ""))))
 
-(defun address@hidden (&optional user channel-data)
+(defun address@hidden (&optional user _channel-data)
   "Format the nickname of USER showing if USER has a voice, is an
 operator, half-op, admin or owner. Owners have \"~\", admins have
 \"&\", operators have \"@\" and users with voice have \"+\" as a
@@ -4770,22 +4770,24 @@
          (hop-ch (cdr (assq ?h prefix)))
          (adm-ch (cdr (assq ?a prefix)))
          (own-ch (cdr (assq ?q prefix)))
-         names name op voice halfop admin owner)
-    (setq names (delete "" (split-string names-string)))
+         (names (delete "" (split-string names-string)))
+        name op voice halfop admin owner)
     (let ((erc-channel-members-changed-hook nil))
       (dolist (item names)
-        (let ((updatep t))
+        (let ((updatep t)
+             (ch (aref item 0)))
           (setq name item op 'off voice 'off halfop 'off admin 'off owner 'off)
-          (if (rassq (elt item 0) prefix)
+          (if (rassq ch prefix)
               (if (= (length item) 1)
                  (setq updatep nil)
                (setq name (substring item 1))
-               (setf (pcase (aref item 0)
+               (setf (pcase ch
                        ((pred (eq voice-ch)) voice)
                        ((pred (eq hop-ch))   halfop)
                        ((pred (eq op-ch))    op)
                        ((pred (eq adm-ch))   admin)
-                       ((pred (eq own-ch))   owner))
+                       ((pred (eq own-ch))   owner)
+                       (_ (error "Unknown prefix char `%S'" ch) voice))
                      'on)))
           (when updatep
             (puthash (erc-downcase name) t
@@ -5086,7 +5088,7 @@
         (list add-modes remove-modes arg-modes))
     nil))
 
-(defun erc-update-modes (tgt mode-string &optional nick host login)
+(defun erc-update-modes (tgt mode-string &optional _nick _host _login)
   "Update the mode information for TGT, provided as MODE-STRING.
 Optional arguments: NICK, HOST and LOGIN - the attributes of the
 person who changed the modes."