[Emacs-diffs] trunk r117977: * lisp/minibuffer.el (completion-at-point): Emit warning for ill-behaved

[Stefan Monnier]

------------------------------------------------------------
revno: 117977
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Mon 2014-09-29 20:48:31 -0400
message:
  * lisp/minibuffer.el (completion-at-point): Emit warning for ill-behaved
  completion functions.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/minibuffer.el             
minibuffer.el-20091113204419-o5vbwnq5f7feedwu-8622

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-09-29 20:25:19 +0000
+++ b/lisp/ChangeLog    2014-09-30 00:48:31 +0000
@@ -1,3 +1,8 @@
+2014-09-30  Stefan Monnier  <address@hidden>
+
+       * minibuffer.el (completion-at-point): Emit warning for ill-behaved
+       completion functions.
+
 2014-09-29  Stefan Monnier  <address@hidden>
 
        * ses.el (ses--letref): Quote value before it gets re-evaluated.

=== modified file 'lisp/minibuffer.el'
--- a/lisp/minibuffer.el        2014-07-08 19:15:28 +0000
+++ b/lisp/minibuffer.el        2014-09-30 00:48:31 +0000
@@ -2106,7 +2106,11 @@
          (completion-in-region start end collection
                                (plist-get plist :predicate))))
       ;; Maybe completion already happened and the function returned t.
-      (_ (cdr res)))))
+      (_
+       (when (cdr res)
+         (message "Warning: %S failed to return valid completion data!"
+                  (car res)))
+       (cdr res)))))
 
 (defun completion-help-at-point ()
   "Display the completions on the text around point.