[Emacs-diffs] emacs-24 r117502: Always use matched specpdl entry to record call arguments (Bug#18473).

[Dmitry Antipov]

------------------------------------------------------------
revno: 117502
revision-id: address@hidden
parent: address@hidden
committer: Dmitry Antipov <address@hidden>
branch nick: emacs-24
timestamp: Tue 2014-09-16 08:04:56 +0400
message:
  Always use matched specpdl entry to record call arguments (Bug#18473).
  * lisp.h (record_in_backtrace): Adjust prototype.
  * eval.c (record_in_backtrace): Return current specpdl level.
  (set_backtrace_args, set_backtrace_nargs): Merge.  Adjust all users.
  (eval_sub, Ffuncall): Record call arguments in matched specpdl
  entry and use that entry in call to backtrace_debug_on_exit.
  (apply_lambda): Likewise.  Get current specpdl level as 3rd arg.
  (do_debug_on_call): Get current specpdl level as 2nd arg.
modified:
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/eval.c                     eval.c-20091113204419-o5vbwnq5f7feedwu-237
  src/lisp.h                     lisp.h-20091113204419-o5vbwnq5f7feedwu-253

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2014-09-15 15:25:54 +0000
+++ b/src/ChangeLog     2014-09-16 04:04:56 +0000
@@ -1,3 +1,14 @@
+2014-09-16  Dmitry Antipov  <address@hidden>
+
+       Always use matched specpdl entry to record call arguments (Bug#18473).
+       * lisp.h (record_in_backtrace): Adjust prototype.
+       * eval.c (record_in_backtrace): Return current specpdl level.
+       (set_backtrace_args, set_backtrace_nargs): Merge.  Adjust all users.
+       (eval_sub, Ffuncall): Record call arguments in matched specpdl
+       entry and use that entry in call to backtrace_debug_on_exit.
+       (apply_lambda): Likewise.  Get current specpdl level as 3rd arg.
+       (do_debug_on_call): Get current specpdl level as 2nd arg.
+
 2014-09-15  Eli Zaretskii  <address@hidden>
 
        Fix display of R2L lines in partial-width windows.

=== modified file 'src/eval.c'
--- a/src/eval.c        2014-09-02 06:29:01 +0000
+++ b/src/eval.c        2014-09-16 04:04:56 +0000
@@ -111,7 +111,7 @@
 union specbinding *backtrace_top (void) EXTERNALLY_VISIBLE;
 
 static Lisp_Object funcall_lambda (Lisp_Object, ptrdiff_t, Lisp_Object *);
-static Lisp_Object apply_lambda (Lisp_Object fun, Lisp_Object args);
+static Lisp_Object apply_lambda (Lisp_Object, Lisp_Object, ptrdiff_t);
 
 static Lisp_Object
 specpdl_symbol (union specbinding *pdl)
@@ -179,17 +179,11 @@
 /* Functions to modify slots of backtrace records.  */
 
 static void
-set_backtrace_args (union specbinding *pdl, Lisp_Object *args)
+set_backtrace_args (union specbinding *pdl, Lisp_Object *args, ptrdiff_t nargs)
 {
   eassert (pdl->kind == SPECPDL_BACKTRACE);
   pdl->bt.args = args;
-}
-
-static void
-set_backtrace_nargs (union specbinding *pdl, ptrdiff_t n)
-{
-  eassert (pdl->kind == SPECPDL_BACKTRACE);
-  pdl->bt.nargs = n;
+  pdl->bt.nargs = nargs;
 }
 
 static void
@@ -341,10 +335,10 @@
 }
 
 static void
-do_debug_on_call (Lisp_Object code)
+do_debug_on_call (Lisp_Object code, ptrdiff_t count)
 {
   debug_on_next_call = 0;
-  set_backtrace_debug_on_exit (specpdl_ptr - 1, true);
+  set_backtrace_debug_on_exit (specpdl + count, true);
   call_debugger (list1 (code));
 }
 
@@ -2039,9 +2033,11 @@
     }
 }
 
-void
+ptrdiff_t
 record_in_backtrace (Lisp_Object function, Lisp_Object *args, ptrdiff_t nargs)
 {
+  ptrdiff_t count = SPECPDL_INDEX ();
+
   eassert (nargs >= UNEVALLED);
   specpdl_ptr->bt.kind = SPECPDL_BACKTRACE;
   specpdl_ptr->bt.debug_on_exit = false;
@@ -2049,6 +2045,8 @@
   specpdl_ptr->bt.args = args;
   specpdl_ptr->bt.nargs = nargs;
   grow_specpdl ();
+
+  return count;
 }
 
 /* Eval a sub-expression of the current expression (i.e. in the same
@@ -2059,6 +2057,7 @@
   Lisp_Object fun, val, original_fun, original_args;
   Lisp_Object funcar;
   struct gcpro gcpro1, gcpro2, gcpro3;
+  ptrdiff_t count;
 
   if (SYMBOLP (form))
     {
@@ -2096,10 +2095,10 @@
   original_args = XCDR (form);
 
   /* This also protects them from gc.  */
-  record_in_backtrace (original_fun, &original_args, UNEVALLED);
+  count = record_in_backtrace (original_fun, &original_args, UNEVALLED);
 
   if (debug_on_next_call)
-    do_debug_on_call (Qt);
+    do_debug_on_call (Qt, count);
 
   /* At this point, only original_fun and original_args
      have values that will be used below.  */
@@ -2151,8 +2150,7 @@
              gcpro3.nvars = argnum;
            }
 
-         set_backtrace_args (specpdl_ptr - 1, vals);
-         set_backtrace_nargs (specpdl_ptr - 1, XINT (numargs));
+         set_backtrace_args (specpdl + count, vals, XINT (numargs));
 
          val = (XSUBR (fun)->function.aMANY) (XINT (numargs), vals);
          UNGCPRO;
@@ -2173,8 +2171,7 @@
 
          UNGCPRO;
 
-         set_backtrace_args (specpdl_ptr - 1, argvals);
-         set_backtrace_nargs (specpdl_ptr - 1, XINT (numargs));
+         set_backtrace_args (specpdl + count, argvals, XINT (numargs));
 
          switch (i)
            {
@@ -2227,7 +2224,7 @@
        }
     }
   else if (COMPILEDP (fun))
-    val = apply_lambda (fun, original_args);
+    val = apply_lambda (fun, original_args, count);
   else
     {
       if (NILP (fun))
@@ -2244,7 +2241,7 @@
        }
       if (EQ (funcar, Qmacro))
        {
-         ptrdiff_t count = SPECPDL_INDEX ();
+         ptrdiff_t count1 = SPECPDL_INDEX ();
          Lisp_Object exp;
          /* Bind lexical-binding during expansion of the macro, so the
             macro can know reliably if the code it outputs will be
@@ -2252,19 +2249,19 @@
          specbind (Qlexical_binding,
                    NILP (Vinternal_interpreter_environment) ? Qnil : Qt);
          exp = apply1 (Fcdr (fun), original_args);
-         unbind_to (count, Qnil);
+         unbind_to (count1, Qnil);
          val = eval_sub (exp);
        }
       else if (EQ (funcar, Qlambda)
               || EQ (funcar, Qclosure))
-       val = apply_lambda (fun, original_args);
+       val = apply_lambda (fun, original_args, count);
       else
        xsignal1 (Qinvalid_function, original_fun);
     }
   check_cons_list ();
 
   lisp_eval_depth--;
-  if (backtrace_debug_on_exit (specpdl_ptr - 1))
+  if (backtrace_debug_on_exit (specpdl + count))
     val = call_debugger (list2 (Qexit, val));
   specpdl_ptr--;
 
@@ -2747,7 +2744,7 @@
   Lisp_Object lisp_numargs;
   Lisp_Object val;
   register Lisp_Object *internal_args;
-  ptrdiff_t i;
+  ptrdiff_t i, count;
 
   QUIT;
 
@@ -2760,13 +2757,13 @@
     }
 
   /* This also GCPROs them.  */
-  record_in_backtrace (args[0], &args[1], nargs - 1);
+  count = record_in_backtrace (args[0], &args[1], nargs - 1);
 
   /* Call GC after setting up the backtrace, so the latter GCPROs the args.  */
   maybe_gc ();
 
   if (debug_on_next_call)
-    do_debug_on_call (Qlambda);
+    do_debug_on_call (Qlambda, count);
 
   check_cons_list ();
 
@@ -2885,14 +2882,14 @@
     }
   check_cons_list ();
   lisp_eval_depth--;
-  if (backtrace_debug_on_exit (specpdl_ptr - 1))
+  if (backtrace_debug_on_exit (specpdl + count))
     val = call_debugger (list2 (Qexit, val));
   specpdl_ptr--;
   return val;
 }
 
 static Lisp_Object
-apply_lambda (Lisp_Object fun, Lisp_Object args)
+apply_lambda (Lisp_Object fun, Lisp_Object args, ptrdiff_t count)
 {
   Lisp_Object args_left;
   ptrdiff_t i;
@@ -2919,15 +2916,14 @@
 
   UNGCPRO;
 
-  set_backtrace_args (specpdl_ptr - 1, arg_vector);
-  set_backtrace_nargs (specpdl_ptr - 1, i);
+  set_backtrace_args (specpdl + count, arg_vector, i);
   tem = funcall_lambda (fun, numargs, arg_vector);
 
   /* Do the debug-on-exit now, while arg_vector still exists.  */
-  if (backtrace_debug_on_exit (specpdl_ptr - 1))
+  if (backtrace_debug_on_exit (specpdl + count))
     {
       /* Don't do it again when we return to eval.  */
-      set_backtrace_debug_on_exit (specpdl_ptr - 1, false);
+      set_backtrace_debug_on_exit (specpdl + count, false);
       tem = call_debugger (list2 (Qexit, tem));
     }
   SAFE_FREE ();

=== modified file 'src/lisp.h'
--- a/src/lisp.h        2014-06-01 07:06:28 +0000
+++ b/src/lisp.h        2014-09-16 04:04:56 +0000
@@ -3955,8 +3955,7 @@
 extern void init_eval (void);
 extern void syms_of_eval (void);
 extern void unwind_body (Lisp_Object);
-extern void record_in_backtrace (Lisp_Object function,
-                                Lisp_Object *args, ptrdiff_t nargs);
+extern ptrdiff_t record_in_backtrace (Lisp_Object, Lisp_Object *, ptrdiff_t);
 extern void mark_specpdl (void);
 extern void get_backtrace (Lisp_Object array);
 Lisp_Object backtrace_top_function (void);