[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-24 r117136: Replace uses of `save-buffer' with `writ
From: |
Dmitry Gutov |
Subject: |
[Emacs-diffs] emacs-24 r117136: Replace uses of `save-buffer' with `write-region' |
Date: |
Wed, 21 May 2014 02:14:55 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 117136
revision-id: address@hidden
parent: address@hidden
fixes bug: http://debbugs.gnu.org/17155
committer: Dmitry Gutov <address@hidden>
branch nick: emacs-24
timestamp: Wed 2014-05-21 05:14:38 +0300
message:
Replace uses of `save-buffer' with `write-region'
* lisp/emacs-lisp/package.el (package--download-one-archive): Use
`write-region' instead of `save-buffer' to avoid running various
hooks.
(describe-package-1): Same. Insert newline at the end of the
buffer if appropriate.
modified:
lisp/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1432
lisp/emacs-lisp/package.el package.el-20100617020707-ybavz666awsxwin6-2
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog 2014-05-20 21:20:36 +0000
+++ b/lisp/ChangeLog 2014-05-21 02:14:38 +0000
@@ -1,3 +1,11 @@
+2014-05-21 Dmitry Gutov <address@hidden>
+
+ * emacs-lisp/package.el (package--download-one-archive): Use
+ `write-region' instead of `save-buffer' to avoid running various
+ hooks. (Bug#17155)
+ (describe-package-1): Same. Insert newline at the end of the
+ buffer if appropriate.
+
2014-05-20 Juri Linkov <address@hidden>
* avoid.el (mouse-avoidance-set-mouse-position): Don't raise frame.
=== modified file 'lisp/emacs-lisp/package.el'
--- a/lisp/emacs-lisp/package.el 2014-05-06 18:11:16 +0000
+++ b/lisp/emacs-lisp/package.el 2014-05-21 02:14:38 +0000
@@ -1254,10 +1254,7 @@
;; may fetch a URL redirect page).
(when (listp (read (current-buffer)))
(make-directory dir t)
- (setq buffer-file-name (expand-file-name file dir))
- (let ((version-control 'never)
- (require-final-newline nil))
- (save-buffer))))
+ (write-region nil nil (expand-file-name file dir) nil 'silent)))
(when good-signatures
;; Write out good signatures into archive-contents.signed file.
(write-region (mapconcat #'epg-signature-to-string good-signatures "\n")
@@ -1503,11 +1500,13 @@
(package--with-work-buffer
(package-archive-base desc)
(format "%s-readme.txt" name)
- (setq buffer-file-name
- (expand-file-name readme package-user-dir))
- (let ((version-control 'never)
- (require-final-newline t))
- (save-buffer))
+ (save-excursion
+ (goto-char (point-max))
+ (unless (bolp)
+ (insert ?\n)))
+ (write-region nil nil
+ (expand-file-name readme package-user-dir)
+ nil 'silent)
(setq readme-string (buffer-string))
t))
(error nil))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] emacs-24 r117136: Replace uses of `save-buffer' with `write-region',
Dmitry Gutov <=