[Emacs-diffs] emacs-24 r116912: Fix bug #16434 with handling the -rv command-line option.

[Eli Zaretskii]

------------------------------------------------------------
revno: 116912
revision-id: address@hidden
parent: address@hidden
fixes bug: http://debbugs.gnu.org/16434
author: Matthias Dahl <address@hidden>
committer: Eli Zaretskii <address@hidden>
branch nick: emacs-24
timestamp: Sat 2014-04-05 10:44:56 +0300
message:
  Fix bug #16434 with handling the -rv command-line option.
  
   lisp/faces.el (make-face-x-resource-internal): Do nothing when
   inhibit-x-resources is non-nil.  Don't touch the default face if
   reversed video is given--as was done in previous versions of Emacs.
   (face-set-after-frame-default): Don't call
   make-face-x-resource-internal here.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/faces.el                  faces.el-20091113204419-o5vbwnq5f7feedwu-562

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-04-05 07:25:52 +0000
+++ b/lisp/ChangeLog    2014-04-05 07:44:56 +0000
@@ -7,6 +7,12 @@
        value is returned if no matching attributes are found.
        (face-spec-recalc): Use the new optional argument when calling
        face-spec-choose.  (Bug#16378)
+       (make-face-x-resource-internal): Do nothing when
+       inhibit-x-resources is non-nil.  Don't touch the default face if
+       reversed video is given--as was done in previous versions of
+       Emacs.
+       (face-set-after-frame-default): Don't call
+       make-face-x-resource-internal here.  (Bug#16434)
 
 2014-04-04  Tassilo Horn  <address@hidden>
 

=== modified file 'lisp/faces.el'
--- a/lisp/faces.el     2014-04-05 07:25:52 +0000
+++ b/lisp/faces.el     2014-04-05 07:44:56 +0000
@@ -334,11 +334,16 @@
 
 (defun make-face-x-resource-internal (face &optional frame)
   "Fill frame-local FACE on FRAME from X resources.
-FRAME nil or not specified means do it for all frames."
-  (if (null frame)
-      (dolist (frame (frame-list))
-       (set-face-attributes-from-resources face frame))
-    (set-face-attributes-from-resources face frame)))
+FRAME nil or not specified means do it for all frames.
+
+If `inhibit-x-resources' is non-nil, this function does nothing."
+  (unless inhibit-x-resources
+    (dolist (frame (if (null frame) (frame-list) (list frame)))
+      ;; `x-create-frame' already took care of correctly handling
+      ;; the reverse video case-- do _not_ touch the default face
+      (unless (and (eq face 'default)
+                  (frame-parameter frame 'reverse))
+        (set-face-attributes-from-resources face frame)))))
 
 
 
@@ -1641,8 +1646,7 @@
   (while (get face 'face-alias)
     (setq face (get face 'face-alias)))
   (face-spec-reset-face face frame)
-  (unless inhibit-x-resources
-    (make-face-x-resource-internal face frame))
+  (make-face-x-resource-internal face frame)
   ;; If FACE is customized or themed, set the custom spec from
   ;; `theme-face' records.
   (let ((theme-faces (get face 'theme-face))
@@ -2045,10 +2049,6 @@
          (progn
            ;; Initialize faces from face spec and custom theme.
            (face-spec-recalc face frame)
-           ;; X resources for the default face are applied during
-           ;; `x-create-frame'.
-           (and (not (eq face 'default)) window-system-p
-                (make-face-x-resource-internal face frame))
            ;; Apply attributes specified by face-new-frame-defaults
            (internal-merge-in-global-face face frame))
        ;; Don't let invalid specs prevent frame creation.