[Emacs-diffs] trunk r114833: * dispextern.h, image.c (x_bitmap_height, x_bitmap_width): Now static.

[Paul Eggert]

------------------------------------------------------------
revno: 114833
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Mon 2013-10-28 14:19:38 -0700
message:
  * dispextern.h, image.c (x_bitmap_height, x_bitmap_width): Now static.
  
  * xfaces.c (load_pixmap): Omit last two args, which are always NULL
  in practice now.  All callers changed.
modified:
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/dispextern.h               
dispextern.h-20091113204419-o5vbwnq5f7feedwu-218
  src/image.c                    image.c-20091113204419-o5vbwnq5f7feedwu-2969
  src/xfaces.c                   xfaces.c-20091113204419-o5vbwnq5f7feedwu-560

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2013-10-28 10:58:01 +0000
+++ b/src/ChangeLog     2013-10-28 21:19:38 +0000
@@ -1,3 +1,9 @@
+2013-10-28  Paul Eggert  <address@hidden>
+
+       * dispextern.h, image.c (x_bitmap_height, x_bitmap_width): Now static.
+       * xfaces.c (load_pixmap): Omit last two args, which are always NULL
+       in practice now.  All callers changed.
+
 2013-10-28  Dmitry Antipov  <address@hidden>
 
        * dispextern.h (struct face): Use bitfields for 'underline_type'

=== modified file 'src/dispextern.h'
--- a/src/dispextern.h  2013-10-28 10:58:01 +0000
+++ b/src/dispextern.h  2013-10-28 21:19:38 +0000
@@ -3274,8 +3274,6 @@
 
 #ifdef HAVE_WINDOW_SYSTEM
 
-extern int x_bitmap_height (struct frame *, ptrdiff_t);
-extern int x_bitmap_width (struct frame *, ptrdiff_t);
 extern ptrdiff_t x_bitmap_pixmap (struct frame *, ptrdiff_t);
 extern void x_reference_bitmap (struct frame *, ptrdiff_t);
 extern ptrdiff_t x_create_bitmap_from_data (struct frame *, char *,

=== modified file 'src/image.c'
--- a/src/image.c       2013-10-14 07:12:49 +0000
+++ b/src/image.c       2013-10-28 21:19:38 +0000
@@ -159,13 +159,13 @@
 
 /* Functions to access the contents of a bitmap, given an id.  */
 
-int
+static int
 x_bitmap_height (struct frame *f, ptrdiff_t id)
 {
   return FRAME_DISPLAY_INFO (f)->bitmaps[id - 1].height;
 }
 
-int
+static int
 x_bitmap_width (struct frame *f, ptrdiff_t id)
 {
   return FRAME_DISPLAY_INFO (f)->bitmaps[id - 1].width;

=== modified file 'src/xfaces.c'
--- a/src/xfaces.c      2013-10-28 10:58:01 +0000
+++ b/src/xfaces.c      2013-10-28 21:19:38 +0000
@@ -853,12 +853,10 @@
    pixmap spec) for use on frame F.  Value is the bitmap_id (see
    xfns.c).  If NAME is nil, return with a bitmap id of zero.  If
    bitmap cannot be loaded, display a message saying so, and return
-   zero.  Store the bitmap width in *W_PTR and its height in *H_PTR,
-   if these pointers are not null.  */
+   zero.  */
 
 static ptrdiff_t
-load_pixmap (struct frame *f, Lisp_Object name, unsigned int *w_ptr,
-            unsigned int *h_ptr)
+load_pixmap (struct frame *f, Lisp_Object name)
 {
   ptrdiff_t bitmap_id;
 
@@ -893,22 +891,12 @@
     {
       add_to_log ("Invalid or undefined bitmap `%s'", name, Qnil);
       bitmap_id = 0;
-
-      if (w_ptr)
-       *w_ptr = 0;
-      if (h_ptr)
-       *h_ptr = 0;
     }
   else
     {
 #ifdef GLYPH_DEBUG
       ++npixmaps_allocated;
 #endif
-      if (w_ptr)
-       *w_ptr = x_bitmap_width (f, bitmap_id);
-
-      if (h_ptr)
-       *h_ptr = x_bitmap_height (f, bitmap_id);
     }
 
   return bitmap_id;
@@ -1298,7 +1286,7 @@
       && !NILP (Fbitmap_spec_p (Vface_default_stipple)))
     {
       x_destroy_bitmap (f, face->stipple);
-      face->stipple = load_pixmap (f, Vface_default_stipple, NULL, NULL);
+      face->stipple = load_pixmap (f, Vface_default_stipple);
     }
 
   face->background = load_color (f, face, bg, LFACE_BACKGROUND_INDEX);
@@ -5719,7 +5707,7 @@
 
   stipple = attrs[LFACE_STIPPLE_INDEX];
   if (!NILP (stipple))
-    face->stipple = load_pixmap (f, stipple, NULL, NULL);
+    face->stipple = load_pixmap (f, stipple);
 #endif /* HAVE_WINDOW_SYSTEM */
 
   return face;