[Emacs-diffs] trunk r114803: * emacs-lisp/ert.el (ert-run-tests-interactively):

[Michael Albinus]

------------------------------------------------------------
revno: 114803
revision-id: address@hidden
parent: address@hidden
committer: Michael Albinus <address@hidden>
branch nick: trunk
timestamp: Fri 2013-10-25 14:07:34 +0200
message:
  * emacs-lisp/ert.el (ert-run-tests-interactively):
  Use `completing-read'.  (Bug#9756)
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/emacs-lisp/ert.el         ert.el-20110112160650-056hnl9qhpjvjicy-2

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2013-10-25 09:45:51 +0000
+++ b/lisp/ChangeLog    2013-10-25 12:07:34 +0000
@@ -1,3 +1,8 @@
+2013-10-25  Michael Albinus  <address@hidden>
+
+       * emacs-lisp/ert.el (ert-run-tests-interactively):
+       Use `completing-read'.  (Bug#9756)
+
 2013-10-25  Eli Zaretskii  <address@hidden>
 
        * simple.el (line-move): Call line-move-1 instead of
@@ -86,7 +91,7 @@
        (ert--stats-set-test-and-result, ert-char-for-test-result)
        (ert-string-for-test-result, ert-run-tests-batch)
        (ert--results-update-ewoc-hf, ert-run-tests-interactively):
-       Handle skipped tests.
+       Handle skipped tests.  (Bug#9803)
 
 2013-10-24  Glenn Morris  <address@hidden>
 

=== modified file 'lisp/emacs-lisp/ert.el'
--- a/lisp/emacs-lisp/ert.el    2013-10-24 07:34:41 +0000
+++ b/lisp/emacs-lisp/ert.el    2013-10-25 12:07:34 +0000
@@ -1881,11 +1881,11 @@
                             ;; defined without cl.
                             (car ert--selector-history)
                           "t")))
-           (read-from-minibuffer (if (null default)
-                                     "Run tests: "
-                                   (format "Run tests (default %s): " default))
-                                 nil nil t 'ert--selector-history
-                                 default nil))
+           (completing-read (if (null default)
+                               "Run tests: "
+                             (format "Run tests (default %s): " default))
+                           obarray #'ert-test-boundp nil nil
+                           'ert--selector-history default nil))
          nil))
   (unless message-fn (setq message-fn 'message))
   (let ((output-buffer-name output-buffer-name)