[Emacs-diffs] trunk r113551: Fix minor problems found by static checking.

[Paul Eggert]

------------------------------------------------------------
revno: 113551
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Fri 2013-07-26 09:39:55 +0100
message:
  Fix minor problems found by static checking.
  
  * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
  (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
modified:
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/eval.c                     eval.c-20091113204419-o5vbwnq5f7feedwu-237

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2013-07-26 07:38:18 +0000
+++ b/src/ChangeLog     2013-07-26 08:39:55 +0000
@@ -1,3 +1,9 @@
+2013-07-26  Paul Eggert  <address@hidden>
+
+       Fix minor problems found by static checking.
+       * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
+       (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
+
 2013-07-26  Stefan Monnier  <address@hidden>
 
        * eval.c (set_specpdl_old_value): New function.

=== modified file 'src/eval.c'
--- a/src/eval.c        2013-07-26 07:38:18 +0000
+++ b/src/eval.c        2013-07-26 08:39:55 +0000
@@ -3424,7 +3424,7 @@
   return Qnil;
 }
 
-union specbinding *
+static union specbinding *
 get_backtrace_frame (Lisp_Object nframes, Lisp_Object base)
 {
   union specbinding *pdl = backtrace_top ();
@@ -3483,7 +3483,7 @@
    pointer-reversal trick.  As it turns out, the rewind does the same as the
    unwind, except it starts from the other end of the spepdl stack, so we use
    the same function for both unwind and rewind.  */
-void
+static void
 backtrace_eval_unrewind (int distance)
 {
   union specbinding *tmp = specpdl_ptr;
@@ -3524,10 +3524,11 @@
              break;
            }
          else
-           /* FALLTHROUGH!
-              NOTE: we only ever come here if make_local_foo was used for
-              the first time on this var within this let.  */
-           ;
+           {
+             /* FALLTHROUGH!
+                NOTE: we only ever come here if make_local_foo was used for
+                the first time on this var within this let.  */
+           }
        case SPECPDL_LET_DEFAULT:
          {
            Lisp_Object sym = specpdl_symbol (tmp);