[Emacs-diffs] trunk r113236: Fix minor problems found by static checking.

[Paul Eggert]

------------------------------------------------------------
revno: 113236
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Sun 2013-06-30 09:14:22 -0700
message:
  Fix minor problems found by static checking.
  
  * lwlib/lwlib-Xaw.h (xaw_update_one_value, xaw_popup_menu):
  * lwlib/lwlib-Xlw.h (xlw_update_one_value, xlw_pop_instance):
  * lwlib/lwlib.h (lw_allow_resizing, lw_set_main_areas) [!USE_MOTIF]:
  Now const.
  * src/widget.c (resize_cb): Remove unused local.
modified:
  lwlib/ChangeLog                changelog-20091113204419-o5vbwnq5f7feedwu-1447
  lwlib/lwlib-Xaw.h              lwlibxaw.h-20091113204419-o5vbwnq5f7feedwu-700
  lwlib/lwlib-Xlw.h              lwlibxlw.h-20091113204419-o5vbwnq5f7feedwu-665
  lwlib/lwlib.h                  lwlib.h-20091113204419-o5vbwnq5f7feedwu-673
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/widget.c                   widget.c-20091113204419-o5vbwnq5f7feedwu-676

=== modified file 'lwlib/ChangeLog'
--- a/lwlib/ChangeLog   2013-06-19 20:10:57 +0000
+++ b/lwlib/ChangeLog   2013-06-30 16:14:22 +0000
@@ -1,3 +1,11 @@
+2013-06-30  Paul Eggert  <address@hidden>
+
+       Fix minor problems found by static checking.
+       * lwlib-Xaw.h (xaw_update_one_value, xaw_popup_menu):
+       * lwlib-Xlw.h (xlw_update_one_value, xlw_pop_instance):
+       * lwlib.h (lw_allow_resizing, lw_set_main_areas) [!USE_MOTIF]:
+       Now const.
+
 2012-10-06  Ulrich Müller  <address@hidden>
 
        * Makefile.in (AR, ARFLAGS): Get values from configure.

=== modified file 'lwlib/lwlib-Xaw.h'
--- a/lwlib/lwlib-Xaw.h 2011-01-15 23:16:57 +0000
+++ b/lwlib/lwlib-Xaw.h 2013-06-30 16:14:22 +0000
@@ -15,16 +15,17 @@
 xaw_update_one_widget (widget_instance *, Widget, widget_value *, Boolean);
 
 void
-xaw_update_one_value (widget_instance *, Widget, widget_value *);
+xaw_update_one_value (widget_instance *, Widget, widget_value *)
+  ATTRIBUTE_CONST;
 
 void
 xaw_destroy_instance (widget_instance *);
 
 void
-xaw_popup_menu (Widget, XEvent *);
+xaw_popup_menu (Widget, XEvent *)
+  ATTRIBUTE_CONST;
 
 void
 xaw_pop_instance (widget_instance *, Boolean);
 
 #endif /* LWLIB_XAW_H */
-

=== modified file 'lwlib/lwlib-Xlw.h'
--- a/lwlib/lwlib-Xlw.h 2011-01-15 23:16:57 +0000
+++ b/lwlib/lwlib-Xlw.h 2013-06-30 16:14:22 +0000
@@ -15,16 +15,17 @@
 
 void
 xlw_update_one_value (widget_instance* instance, Widget widget,
-                      widget_value* val);
+                     widget_value* val)
+  ATTRIBUTE_CONST;
 
 void
 xlw_destroy_instance (widget_instance* instance);
 
 void
-xlw_pop_instance (widget_instance* instance, Boolean up);
+xlw_pop_instance (widget_instance* instance, Boolean up)
+  ATTRIBUTE_CONST;
 
 void
 xlw_popup_menu (Widget widget, XEvent * event);
 
 #endif /* LWLIB_XLW_H */
-

=== modified file 'lwlib/lwlib.h'
--- a/lwlib/lwlib.h     2013-01-01 09:11:05 +0000
+++ b/lwlib/lwlib.h     2013-06-30 16:14:22 +0000
@@ -171,9 +171,15 @@
 Boolean lw_window_is_in_menubar (Window win, Widget menubar_widget);
 
 /* Manage resizing: TRUE permits resizing widget w; FALSE disallows it. */
+#ifndef USE_MOTIF
+ATTRIBUTE_CONST
+#endif
 void lw_allow_resizing (Widget w, Boolean flag);
 
 /* Set up the main window. */
+#ifndef USE_MOTIF
+ATTRIBUTE_CONST
+#endif
 void lw_set_main_areas (Widget parent,
                         Widget menubar,
                         Widget work_area);

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2013-06-30 15:33:01 +0000
+++ b/src/ChangeLog     2013-06-30 16:14:22 +0000
@@ -1,5 +1,7 @@
 2013-06-30  Paul Eggert  <address@hidden>
 
+       * widget.c (resize_cb): Remove unused local.
+
        Do not use GTK 3 if it exists but cannot be compiled.
        * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
        * xterm.c (x_error_handler) [!USE_GTK]:

=== modified file 'src/widget.c'
--- a/src/widget.c      2013-01-02 16:13:04 +0000
+++ b/src/widget.c      2013-06-30 16:14:22 +0000
@@ -656,7 +656,6 @@
            XEvent* event,
            Boolean* continue_to_dispatch)
 {
-  EmacsFrame ew = (EmacsFrame) widget;
   EmacsFrameResize (widget);
 }