[Emacs-diffs] trunk r112898: Fix Eshell bug

[Aidan Gauland]

------------------------------------------------------------
revno: 112898
revision-id: address@hidden
parent: address@hidden
committer: Aidan Gauland <address@hidden>
branch nick: trunk
timestamp: Sun 2013-06-09 18:44:47 +1200
message:
  Fix Eshell bug
  
  * eshell/em-term.el (eshell-visual-command-p): Fix bug that
    causedoutput redirection to be ignored with visual commands.

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2013-06-09 06:39:40 +0000
+++ b/lisp/ChangeLog    2013-06-09 06:44:47 +0000
@@ -1,5 +1,10 @@
 2013-06-09  Aidan Gauland  <address@hidden>
 
+       * eshell/em-term.el (eshell-visual-command-p): Fix bug that caused
+       output redirection to be ignored with visual commands.
+
+2013-06-09  Aidan Gauland  <address@hidden>
+
        * eshell/em-term.el (eshell-visual-command-p): New function.
        (eshell-term-initialize): Move long lambda to separate function 
eshell-visual-command-p.
        * eshell/em-dirs.el (eshell-dirs-initialise): Add missing #' to lambda.

=== modified file 'lisp/eshell/em-term.el'
--- a/lisp/eshell/em-term.el    2013-06-09 06:39:40 +0000
+++ b/lisp/eshell/em-term.el    2013-06-09 06:44:47 +0000
@@ -141,12 +141,13 @@
 If either COMMAND or a subcommand in ARGS (e.g. git log) is a
 visual command, returns non-nil."
   (let ((command (file-name-nondirectory command)))
-    (or (member command eshell-visual-commands)
-        (member (car args)
-                (cdr (assoc command eshell-visual-subcommands)))
-        (cl-intersection args
-                         (cdr (assoc command eshell-visual-options))
-                         :test 'string=))))
+    (and (eshell-interactive-output-p)
+         (or (member command eshell-visual-commands)
+             (member (car args)
+                     (cdr (assoc command eshell-visual-subcommands)))
+             (cl-intersection args
+                              (cdr (assoc command eshell-visual-options))
+                              :test 'string=)))))
 
 (defun eshell-exec-visual (&rest args)
   "Run the specified PROGRAM in a terminal emulation buffer.