[Emacs-diffs] /srv/bzr/emacs/trunk r112763: Silence some gnus compilation warnings

[Glenn Morris]

------------------------------------------------------------
revno: 112763
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Tue 2013-05-28 19:40:43 -0700
message:
  Silence some gnus compilation warnings
  
  * gnus/gnus-ems.el (set-process-plist): Every supported Emacs has this.
  
  * gnus/gnus-group.el (gnus-sequence-of-unread-articles)
  (gnus-summary-add-mark, gnus-mark-article-as-read)
  (gnus-group-make-articles-read): Declare.
  
  * gnus/gnus-sum.el (gnus-parameter-list-identifier)
  (gnus-article-stop-animations, gnus-stop-downloads)
  (gnus-article-only-boring-p, article-goto-body)
  (gnus-flush-original-article-buffer, article-narrow-to-head)
  (gnus-article-hidden-text-p, gnus-delete-wash-type)
  (gnus-summary-save-in-pipe, gnus-article-show-summary): Declare.
  
  * gnus/gnus.el: No need to eval-and-compile autoloads.
  
  * gnus/gravatar.el (help-function-arglist): Autoload.
  
  * gnus/nnimap.el (gnus-refer-thread-use-nnir): Declare.
  
  * gnus/nnmail.el (nnmail-fancy-expiry-target): Maybe use mail-dont-reply-to.
  
  * gnus/spam.el: No need to load spam-report when compiling.
  No need to eval-and-compile autoloads.
  (spam-report-resend-to): Declare.
  (spam-report-resend-register-routine): Require 'spam-report.
modified:
  lisp/gnus/ChangeLog
  lisp/gnus/gnus-ems.el
  lisp/gnus/gnus-group.el
  lisp/gnus/gnus-sum.el
  lisp/gnus/gnus.el
  lisp/gnus/gravatar.el
  lisp/gnus/nnimap.el
  lisp/gnus/nnmail.el
  lisp/gnus/spam.el

=== modified file 'lisp/gnus/ChangeLog'
--- a/lisp/gnus/ChangeLog       2013-05-24 14:36:12 +0000
+++ b/lisp/gnus/ChangeLog       2013-05-29 02:40:43 +0000
@@ -1,3 +1,31 @@
+2013-05-29  Glenn Morris  <address@hidden>
+
+       * gnus-ems.el (set-process-plist): Every supported Emacs has this.
+
+       * gnus-group.el (gnus-sequence-of-unread-articles)
+       (gnus-summary-add-mark, gnus-mark-article-as-read)
+       (gnus-group-make-articles-read): Declare.
+
+       * gnus-sum.el (gnus-parameter-list-identifier)
+       (gnus-article-stop-animations, gnus-stop-downloads)
+       (gnus-article-only-boring-p, article-goto-body)
+       (gnus-flush-original-article-buffer, article-narrow-to-head)
+       (gnus-article-hidden-text-p, gnus-delete-wash-type)
+       (gnus-summary-save-in-pipe, gnus-article-show-summary): Declare.
+
+       * gnus.el: No need to eval-and-compile autoloads.
+
+       * gravatar.el (help-function-arglist): Autoload.
+
+       * nnimap.el (gnus-refer-thread-use-nnir): Declare.
+
+       * nnmail.el (nnmail-fancy-expiry-target): Maybe use mail-dont-reply-to.
+
+       * spam.el: No need to load spam-report when compiling.
+       No need to eval-and-compile autoloads.
+       (spam-report-resend-to): Declare.
+       (spam-report-resend-register-routine): Require 'spam-report.
+
 2013-05-24  Julien Danjou  <address@hidden>
 
        * sieve.el (sieve-setup-buffer): Fix default port value in sieve buffer

=== modified file 'lisp/gnus/gnus-ems.el'
--- a/lisp/gnus/gnus-ems.el     2013-01-01 09:11:05 +0000
+++ b/lisp/gnus/gnus-ems.el     2013-05-29 02:40:43 +0000
@@ -221,8 +221,8 @@
         'window-inside-pixel-edges
       'window-pixel-edges))
 
-  (if (fboundp 'set-process-plist)
-      (progn
+  (if (or (featurep 'emacs) (fboundp 'set-process-plist))
+      (progn                           ; these exist since Emacs 22.1
        (defalias 'gnus-set-process-plist 'set-process-plist)
        (defalias 'gnus-process-plist 'process-plist)
        (defalias 'gnus-process-get 'process-get)

=== modified file 'lisp/gnus/gnus-group.el'
--- a/lisp/gnus/gnus-group.el   2013-02-13 04:31:09 +0000
+++ b/lisp/gnus/gnus-group.el   2013-05-29 02:40:43 +0000
@@ -3591,6 +3591,8 @@
   (interactive "P")
   (gnus-group-catchup-current n 'all))
 
+(declare-function gnus-sequence-of-unread-articles "gnus-sum" (group))
+
 (defun gnus-group-catchup (group &optional all)
   "Mark all articles in GROUP as read.
 If ALL is non-nil, all articles are marked as read.
@@ -4493,6 +4495,8 @@
                     (sort (nconc (gnus-uncompress-range (cdr m))
                                  (copy-sequence articles)) '<) t))))))
 
+(declare-function gnus-summary-add-mark "gnus-sum" (article type))
+
 (defun gnus-add-mark (group mark article)
   "Mark ARTICLE in GROUP with MARK, whether the group is displayed or not."
   (let ((buffer (gnus-summary-buffer-name group)))
@@ -4657,6 +4661,9 @@
   (let ((gnus-group-list-option 'limit))
     (gnus-group-list-plus args)))
 
+(declare-function gnus-mark-article-as-read "gnu-sum" (article &optional mark))
+(declare-function gnus-group-make-articles-read "gnus-sum" (group articles))
+
 (defun gnus-group-mark-article-read (group article)
   "Mark ARTICLE read."
   (let ((buffer (gnus-summary-buffer-name group))

=== modified file 'lisp/gnus/gnus-sum.el'
--- a/lisp/gnus/gnus-sum.el     2013-05-04 22:38:05 +0000
+++ b/lisp/gnus/gnus-sum.el     2013-05-29 02:40:43 +0000
@@ -5492,6 +5492,8 @@
         (cdr (assq number gnus-newsgroup-scored))
         (memq number gnus-newsgroup-processable))))))
 
+(declare-function gnus-parameter-list-identifier "gnus-art" (name) t)
+
 (defun gnus-group-get-list-identifiers (group)
   "Get list identifier regexp for GROUP."
   (or (gnus-parameter-list-identifier group)
@@ -7267,6 +7269,9 @@
       (unless quit-config
        (setq gnus-newsgroup-name nil)))))
 
+(declare-function gnus-article-stop-animations "gnus-art" ())
+(declare-function gnus-stop-downloads "gnus-art" ())
+
 (defalias 'gnus-summary-quit 'gnus-summary-exit-no-update)
 (defun gnus-summary-exit-no-update (&optional no-questions)
   "Quit reading current newsgroup without updating read article info."
@@ -7859,6 +7864,8 @@
    (and gnus-auto-select-same
        (gnus-summary-article-subject))))
 
+(declare-function gnus-article-only-boring-p "gnus-art" ())
+
 (defun gnus-summary-next-page (&optional lines circular stop)
   "Show next page of the selected article.
 If at the end of the current article, select the next article.
@@ -8426,6 +8433,8 @@
   (interactive "sMatch headers (regexp): \nP")
   (gnus-summary-limit-to-bodies match reverse t))
 
+(declare-function article-goto-body "gnus-art" ())
+
 (defun gnus-summary-limit-to-bodies (match &optional reverse headersp)
   "Limit the summary buffer to articles that have bodies that match MATCH.
 If REVERSE (the prefix), limit to articles that don't match."
@@ -9556,6 +9565,8 @@
          (ps-spool-buffer-with-faces)
        (ps-spool-buffer)))))
 
+(declare-function gnus-flush-original-article-buffer "gnus-art" ())
+
 (defun gnus-summary-show-complete-article ()
   "Show a complete version of the current article.
 This is only useful if you're looking at a partial version of the
@@ -9679,6 +9690,10 @@
               t)))
   (gnus-summary-show-article))
 
+(declare-function article-narrow-to-head "gnus-art" ())
+(declare-function gnus-article-hidden-text-p "gnus-art" (type))
+(declare-function gnus-delete-wash-type "gnus-art" (type))
+
 (defun gnus-summary-toggle-header (&optional arg)
   "Show the headers if they are hidden, or hide them if they are shown.
 If ARG is a positive number, show the entire header.
@@ -11962,6 +11977,8 @@
     (gnus-set-mode-line 'summary)
     n))
 
+(declare-function gnus-summary-save-in-pipe "gnus-art" (&optional command raw))
+
 (defun gnus-summary-pipe-output (&optional n sym)
   "Pipe the current article to a subprocess.
 If N is a positive number, pipe the N next articles.
@@ -12914,6 +12931,7 @@
   (gnus-summary-position-point))
 
 ;;; Bookmark support for Gnus.
+(declare-function gnus-article-show-summary "gnus-art" ())
 (declare-function bookmark-make-record-default
                   "bookmark" (&optional no-file no-context posn))
 (declare-function bookmark-prop-get "bookmark" (bookmark prop))

=== modified file 'lisp/gnus/gnus.el'
--- a/lisp/gnus/gnus.el 2013-05-09 01:40:20 +0000
+++ b/lisp/gnus/gnus.el 2013-05-29 02:40:43 +0000
@@ -4243,8 +4243,7 @@
       (setq valids (cdr valids)))
     outs))
 
-(eval-and-compile
-  (autoload 'message-y-or-n-p "message" nil nil 'macro))
+(autoload 'message-y-or-n-p "message" nil nil 'macro)
 
 (defun gnus-read-group (prompt &optional default)
   "Prompt the user for a group name.

=== modified file 'lisp/gnus/gravatar.el'
--- a/lisp/gnus/gravatar.el     2013-01-01 09:11:05 +0000
+++ b/lisp/gnus/gravatar.el     2013-05-29 02:40:43 +0000
@@ -103,6 +103,8 @@
        (gravatar-create-image data nil t)
       'error)))
 
+(autoload 'help-function-arglist "help-fns")
+
 ;;;###autoload
 (defun gravatar-retrieve (mail-address cb &optional cbargs)
   "Retrieve MAIL-ADDRESS gravatar and call CB on retrieval.

=== modified file 'lisp/gnus/nnimap.el'
--- a/lisp/gnus/nnimap.el       2013-01-15 04:26:28 +0000
+++ b/lisp/gnus/nnimap.el       2013-05-29 02:40:43 +0000
@@ -1642,6 +1642,7 @@
   (setq nnimap-status-string "Read-only server")
   nil)
 
+(defvar gnus-refer-thread-use-nnir)    ; gnus-sum
 (declare-function gnus-fetch-headers "gnus-sum"
                  (articles &optional limit force-new dependencies))
 

=== modified file 'lisp/gnus/nnmail.el'
--- a/lisp/gnus/nnmail.el       2013-02-12 17:36:54 +0000
+++ b/lisp/gnus/nnmail.el       2013-05-29 02:40:43 +0000
@@ -1954,7 +1954,9 @@
                 (and (string-match (cadr regexp-target-pair) to)
                      (let ((rmail-dont-reply-to-names
                             (message-dont-reply-to-names)))
-                       (equal (rmail-dont-reply-to from) "")))))
+                       (equal (if (fboundp 'rmail-dont-reply-to)
+                                  (rmail-dont-reply-to from)
+                                (mail-dont-reply-to from)) "")))))
        (setq target (format-time-string (caddr regexp-target-pair) date)))
        ((and (not (equal header 'to-from))
             (string-match (cadr regexp-target-pair)

=== modified file 'lisp/gnus/spam.el'
--- a/lisp/gnus/spam.el 2013-05-09 01:40:20 +0000
+++ b/lisp/gnus/spam.el 2013-05-29 02:40:43 +0000
@@ -50,7 +50,6 @@
 ;;; for the definitions of group content classification and spam processors
 (require 'gnus)
 
-(eval-when-compile (require 'spam-report))
 (eval-when-compile (require 'hashcash))
 
 ;; for nnimap-split-download-body-default
@@ -60,11 +59,10 @@
 (autoload 'query-dig "dig")
 
 ;; autoload spam-report
-(eval-and-compile
-  (autoload 'spam-report-gmane "spam-report")
-  (autoload 'spam-report-gmane-spam "spam-report")
-  (autoload 'spam-report-gmane-ham "spam-report")
-  (autoload 'spam-report-resend "spam-report"))
+(autoload 'spam-report-gmane "spam-report")
+(autoload 'spam-report-gmane-spam "spam-report")
+(autoload 'spam-report-gmane-ham "spam-report")
+(autoload 'spam-report-resend "spam-report")
 
 ;; autoload gnus-registry
 (autoload 'gnus-registry-group-count "gnus-registry")
@@ -2473,7 +2471,10 @@
 (defun spam-report-resend-register-ham-routine (articles)
   (spam-report-resend-register-routine articles t))
 
+(defvar spam-report-resend-to)
+
 (defun spam-report-resend-register-routine (articles &optional ham)
+  (require 'spam-report)
   (let* ((resend-to-gp
           (if ham
               (gnus-parameter-ham-resend-to gnus-newsgroup-name)