[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] /srv/bzr/emacs/trunk r112681: Silence some js compilation
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] /srv/bzr/emacs/trunk r112681: Silence some js compilation warnings |
Date: |
Thu, 23 May 2013 00:37:56 -0700 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 112681
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Thu 2013-05-23 00:37:56 -0700
message:
Silence some js compilation warnings
* lisp/progmodes/js.el: No need to load comint when compiling.
(ring-insert, comint-send-string, comint-send-input)
(comint-last-input-end, ido-chop): Declare.
modified:
lisp/ChangeLog
lisp/progmodes/js.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog 2013-05-23 07:10:05 +0000
+++ b/lisp/ChangeLog 2013-05-23 07:37:56 +0000
@@ -1,5 +1,9 @@
2013-05-23 Glenn Morris <address@hidden>
+ * progmodes/js.el: No need to load comint when compiling.
+ (ring-insert, comint-send-string, comint-send-input)
+ (comint-last-input-end, ido-chop): Declare.
+
* vc/ediff-diff.el, vc/ediff-merg.el: Require ediff-util at run-time.
* vc/ediff-mult.el: Adjust requires.
(ediff-directories-internal, ediff-directory-revisions-internal)
=== modified file 'lisp/progmodes/js.el'
--- a/lisp/progmodes/js.el 2013-03-07 16:08:33 +0000
+++ b/lisp/progmodes/js.el 2013-05-23 07:37:56 +0000
@@ -55,7 +55,6 @@
(eval-when-compile
(require 'cl-lib)
- (require 'comint)
(require 'ido))
(defvar inferior-moz-buffer)
@@ -2217,6 +2216,9 @@
(defvar find-tag-marker-ring) ; etags
+;; etags loads ring.
+(declare-function ring-insert "ring" (ring item))
+
(defun js-find-symbol (&optional arg)
"Read a JavaScript symbol and jump to it.
With a prefix argument, restrict symbols to those from the
@@ -2639,6 +2641,11 @@
;; order to catch a prompt that's only partially arrived
(save-excursion (forward-line 0) (point))))
+;; Presumably "inferior-moz-process" loads comint.
+(declare-function comint-send-string "comint" (process string))
+(declare-function comint-send-input "comint"
+ (&optional no-newline artificial))
+
(defun js--js-enter-repl ()
(inferior-moz-process) ; called for side-effect
(with-current-buffer inferior-moz-buffer
@@ -2824,6 +2831,8 @@
(`error (signal 'js-js-error (list (cl-second result))))
(x (error "Unmatched case in js--js-decode-retval: %S" x))))
+(defvar comint-last-input-end)
+
(defun js--js-funcall (function &rest arguments)
"Call the Mozilla function FUNCTION with arguments ARGUMENTS.
If function is a string, look it up as a property on the global
@@ -2996,6 +3005,8 @@
(defvar js-read-tab-history nil)
+(declare-function ido-chop "ido" (items elem))
+
(defun js--read-tab (prompt)
"Read a Mozilla tab with prompt PROMPT.
Return a cons of (TYPE . OBJECT). TYPE is either 'window or
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] /srv/bzr/emacs/trunk r112681: Silence some js compilation warnings,
Glenn Morris <=