emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r110629: * net/tramp-smb.el (tramp-sm


From: Michael Albinus
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r110629: * net/tramp-smb.el (tramp-smb-maybe-open-connection): Set
Date: Tue, 23 Oct 2012 16:26:30 +0200
User-agent: Bazaar (2.5.0)

------------------------------------------------------------
revno: 110629
committer: Michael Albinus <address@hidden
branch nick: trunk
timestamp: Tue 2012-10-23 16:26:30 +0200
message:
  * net/tramp-smb.el (tramp-smb-maybe-open-connection): Set
  `tramp-chunksize' to 1.  This improves the performance.
  (tramp-smb-wait-for-output): Add timeout to
  `tramp-accept-process-output' calls.
modified:
  lisp/ChangeLog
  lisp/net/tramp-smb.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-10-23 02:39:13 +0000
+++ b/lisp/ChangeLog    2012-10-23 14:26:30 +0000
@@ -1,3 +1,10 @@
+2012-10-23  Michael Albinus  <address@hidden>
+
+       * net/tramp-smb.el (tramp-smb-maybe-open-connection): Set
+       `tramp-chunksize' to 1.  This improves the performance.
+       (tramp-smb-wait-for-output): Add timeout to
+       `tramp-accept-process-output' calls.
+
 2012-10-23  Chong Yidong  <address@hidden>
 
        * faces.el (font-list-limit): Define as an obsolete variable.

=== modified file 'lisp/net/tramp-smb.el'
--- a/lisp/net/tramp-smb.el     2012-10-09 12:49:02 +0000
+++ b/lisp/net/tramp-smb.el     2012-10-23 14:26:30 +0000
@@ -1677,11 +1677,11 @@
                          (tramp-set-connection-property
                           vec "smbserver-version" smbserver-version))))
 
-                   ;; Set chunksize.  Otherwise, `tramp-send-string' might
-                   ;; try it itself.
+                   ;; Set chunksize to 1.  smbclient reads its input
+                   ;; character by character; if we send the string
+                   ;; at once, it is read painfully slow.
                    (tramp-set-connection-property p "smb-share" share)
-                   (tramp-set-connection-property
-                    p "chunksize" tramp-chunksize))
+                   (tramp-set-connection-property p "chunksize" 1))
 
                ;; Check for the error reason.  If it was due to wrong
                ;; password, reestablish the connection.  We cannot
@@ -1717,7 +1717,7 @@
       (while (and (not found) (not err) (memq (process-status p) '(run open)))
 
        ;; Accept pending output.
-       (tramp-accept-process-output p)
+       (tramp-accept-process-output p 0.1)
 
        ;; Search for prompt.
        (goto-char (point-min))
@@ -1731,7 +1731,7 @@
       (while (and (not found) (memq (process-status p) '(run open)))
 
        ;; Accept pending output.
-       (tramp-accept-process-output p)
+       (tramp-accept-process-output p 0.1)
 
        ;; Search for prompt.
        (goto-char (point-min))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]