[Emacs-diffs] /srv/bzr/emacs/trunk r108409: Fix bug #11513 with raise-frame on MS-Windows.

[Eli Zaretskii]

------------------------------------------------------------
revno: 108409
fixes bug: http://debbugs.gnu.org/11513
committer: Eli Zaretskii <address@hidden>
branch nick: trunk
timestamp: Mon 2012-05-28 20:22:40 +0300
message:
  Fix bug #11513 with raise-frame on MS-Windows.
  
   src/w32term.c (my_bring_window_to_top): New function.
   (x_raise_frame): Use handle returned by DeferWindowPos, which
   could be different from the original one.  Call
   my_bring_window_to_top instead of my_set_foreground_window.
   src/w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
   by calling BringWindowToTop.
   src/w32term.h (WM_EMACS_BRINGTOTOP): New message.
   (WM_EMACS_END): Increase by one.
modified:
  src/ChangeLog
  src/w32fns.c
  src/w32term.c
  src/w32term.h

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-05-28 07:13:45 +0000
+++ b/src/ChangeLog     2012-05-28 17:22:40 +0000
@@ -1,3 +1,17 @@
+2012-05-28  Eli Zaretskii  <address@hidden>
+
+       * w32term.c (my_bring_window_to_top): New function.
+       (x_raise_frame): Use handle returned by DeferWindowPos, which
+       could be different from the original one.  Call
+       my_bring_window_to_top instead of my_set_foreground_window.
+       (Bug#11513)
+
+       * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
+       by calling BringWindowToTop.
+
+       * w32term.h (WM_EMACS_BRINGTOTOP): New message.
+       (WM_EMACS_END): Increase by one.
+
 2012-05-28  Paul Eggert  <address@hidden>
 
        * bidi.c (bidi_mirror_char): Put eassert before conversion to int.

=== modified file 'src/w32fns.c'
--- a/src/w32fns.c      2012-05-25 18:19:24 +0000
+++ b/src/w32fns.c      2012-05-28 17:22:40 +0000
@@ -3663,6 +3663,7 @@
     case WM_EMACS_SHOWWINDOW:
       return ShowWindow ((HWND) wParam, (WPARAM) lParam);
 
+    case WM_EMACS_BRINGTOTOP:
     case WM_EMACS_SETFOREGROUND:
       {
         HWND foreground_window;
@@ -3680,6 +3681,8 @@
           foreground_thread = 0;
 
         retval = SetForegroundWindow ((HWND) wParam);
+        if (msg == WM_EMACS_BRINGTOTOP)
+          retval = BringWindowToTop ((HWND) wParam);
 
         /* Detach from the previous foreground thread.  */
         if (foreground_thread)

=== modified file 'src/w32term.c'
--- a/src/w32term.c     2012-05-18 08:36:50 +0000
+++ b/src/w32term.c     2012-05-28 17:22:40 +0000
@@ -3492,6 +3492,12 @@
               (WPARAM) hwnd, 0);
 }
 
+static void
+my_bring_window_to_top (HWND hwnd)
+{
+  SendMessage (hwnd, WM_EMACS_BRINGTOTOP, (WPARAM) hwnd, 0);
+}
+
 /* Create a scroll bar and return the scroll bar vector for it.  W is
    the Emacs window on which to create the scroll bar. TOP, LEFT,
    WIDTH and HEIGHT are the pixel coordinates and dimensions of the
@@ -5600,24 +5606,27 @@
       HDWP handle = BeginDeferWindowPos (2);
       if (handle)
        {
-         DeferWindowPos (handle,
-                         FRAME_W32_WINDOW (f),
-                         HWND_TOP,
-                         0, 0, 0, 0,
-                         SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE);
-
-         DeferWindowPos (handle,
-                         GetForegroundWindow (),
-                         FRAME_W32_WINDOW (f),
-                         0, 0, 0, 0,
-                         SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE);
-
-         EndDeferWindowPos (handle);
+         handle = DeferWindowPos (handle,
+                                  FRAME_W32_WINDOW (f),
+                                  HWND_TOP,
+                                  0, 0, 0, 0,
+                                  SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE);
+         if (handle)
+           {
+             handle = DeferWindowPos (handle,
+                                      GetForegroundWindow (),
+                                      FRAME_W32_WINDOW (f),
+                                      0, 0, 0, 0,
+                                      SWP_NOSIZE | SWP_NOMOVE |
+                                      SWP_NOACTIVATE);
+             if (handle)
+               EndDeferWindowPos (handle);
+           }
        }
     }
   else
     {
-      my_set_foreground_window (FRAME_W32_WINDOW (f));
+      my_bring_window_to_top (FRAME_W32_WINDOW (f));
     }
 
   UNBLOCK_INPUT;

=== modified file 'src/w32term.h'
--- a/src/w32term.h     2012-01-19 07:21:25 +0000
+++ b/src/w32term.h     2012-05-28 17:22:40 +0000
@@ -576,7 +576,8 @@
 #define WM_EMACS_HIDE_CARET            (WM_EMACS_START + 18)
 #define WM_EMACS_SETCURSOR             (WM_EMACS_START + 19)
 #define WM_EMACS_PAINT                 (WM_EMACS_START + 20)
-#define WM_EMACS_END                   (WM_EMACS_START + 21)
+#define WM_EMACS_BRINGTOTOP            (WM_EMACS_START + 21)
+#define WM_EMACS_END                   (WM_EMACS_START + 22)
 
 #define WND_FONTWIDTH_INDEX    (0)
 #define WND_LINEHEIGHT_INDEX   (4)