[Emacs-diffs] /srv/bzr/emacs/trunk r108174: Encoding fix for browse-url-encode-url.

[Chong Yidong]

------------------------------------------------------------
revno: 108174
fixes bug(s): http://debbugs.gnu.org/6300
committer: Chong Yidong <address@hidden>
branch nick: trunk
timestamp: Wed 2012-05-09 20:39:40 +0800
message:
  Encoding fix for browse-url-encode-url.
  
  * lisp/net/browse-url.el (browse-url-url-encode-chars): Use upper-case.
  (browse-url-encode-url): Encode spaces and quotes.
modified:
  lisp/ChangeLog
  lisp/net/browse-url.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-05-09 03:30:51 +0000
+++ b/lisp/ChangeLog    2012-05-09 12:39:40 +0000
@@ -1,3 +1,8 @@
+2012-05-09  Chong Yidong  <address@hidden>
+
+       * net/browse-url.el (browse-url-url-encode-chars): Use upper-case.
+       (browse-url-encode-url): Encode spaces and quotes (Bug#6300).
+
 2012-05-09  Stefan Monnier  <address@hidden>
 
        * shell.el (shell-completion-vars): Fix last change (bug#11348).

=== modified file 'lisp/net/browse-url.el'
--- a/lisp/net/browse-url.el    2012-04-13 15:15:42 +0000
+++ b/lisp/net/browse-url.el    2012-05-09 12:39:40 +0000
@@ -642,7 +642,7 @@
        (s 0))
     (while (setq s (string-match chars encoded-text s))
       (setq encoded-text
-           (replace-match (format "%%%x"
+           (replace-match (format "%%%X"
                                   (string-to-char (match-string 0 
encoded-text)))
                           t t encoded-text)
            s (1+ s)))
@@ -655,7 +655,7 @@
   ;; FIXME: Is there an actual example of a web browser getting
   ;; confused?  (This used to encode commas, but at least Firefox
   ;; handles commas correctly and doesn't accept encoded commas.)
-  (browse-url-url-encode-chars url "[)$]"))
+  (browse-url-url-encode-chars url "[\")$] "))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; URL input