[Emacs-diffs] /srv/bzr/emacs/trunk r107856: * lisp/progmodes/flymake.el (flymake-mode): Beware read-only dirs.

[Stefan Monnier]

------------------------------------------------------------
revno: 107856
fixes bug(s): http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8954
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Tue 2012-04-10 20:21:00 -0400
message:
  * lisp/progmodes/flymake.el (flymake-mode): Beware read-only dirs.
modified:
  lisp/ChangeLog
  lisp/progmodes/flymake.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-04-10 23:34:25 +0000
+++ b/lisp/ChangeLog    2012-04-11 00:21:00 +0000
@@ -1,3 +1,7 @@
+2012-04-11  Stefan Monnier  <address@hidden>
+
+       * progmodes/flymake.el (flymake-mode): Beware read-only dirs (bug#8954).
+
 2012-04-10  Sébastien Gross  <address@hidden>  (tiny change)
 
        * progmodes/hideshow.el (hs-hide-all): Don't infloop on comments

=== modified file 'lisp/progmodes/flymake.el'
--- a/lisp/progmodes/flymake.el 2012-02-08 02:12:24 +0000
+++ b/lisp/progmodes/flymake.el 2012-04-11 00:21:00 +0000
@@ -1356,8 +1356,12 @@
       (setq flymake-timer
             (run-at-time nil 1 'flymake-on-timer-event (current-buffer)))
 
-      (when flymake-start-syntax-check-on-find-file
-        (flymake-start-syntax-check)))))
+      (when (and flymake-start-syntax-check-on-find-file
+                 ;; Since we write temp files in current dir, there's no point
+                 ;; trying if the directory is read-only (bug#8954).
+                 (file-writable-p (file-name-directory buffer-file-name)))
+        (with-demoted-errors
+          (flymake-start-syntax-check))))))
 
    ;; Turning the mode OFF.
    (t