emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r104434: Decode all incoming messages


From: Leo Liu
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r104434: Decode all incoming messages in rcirc.el
Date: Mon, 30 May 2011 20:23:56 +0800
User-agent: Bazaar (2.3.1)

------------------------------------------------------------
revno: 104434
committer: Leo Liu <address@hidden>
branch nick: trunk
timestamp: Mon 2011-05-30 20:23:56 +0800
message:
  Decode all incoming messages in rcirc.el
  
  Also allow automatic coding system detection if
  rcirc-decode-coding-system is nil.
  
  See discussion in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8744
modified:
  lisp/ChangeLog
  lisp/net/rcirc.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-05-30 12:04:44 +0000
+++ b/lisp/ChangeLog    2011-05-30 12:23:56 +0000
@@ -1,6 +1,9 @@
 2011-05-30  Leo Liu  <address@hidden>
 
        * net/rcirc.el (rcirc-debug-buffer): Use visible buffer name.
+       (rcirc-print): Decode all incoming messages (bug#8744).
+       (rcirc-decode-coding-system): Allow value nil for automatic coding
+       system detection.
 
 2011-05-29  Chong Yidong  <address@hidden>
 

=== modified file 'lisp/net/rcirc.el'
--- a/lisp/net/rcirc.el 2011-05-30 12:04:44 +0000
+++ b/lisp/net/rcirc.el 2011-05-30 12:23:56 +0000
@@ -314,9 +314,11 @@
   :type 'boolean
   :group 'rcirc)
 
-(defcustom rcirc-decode-coding-system 'utf-8
-  "Coding system used to decode incoming irc messages."
+(defcustom rcirc-decode-coding-system nil
+  "Coding system used to decode incoming irc messages.
+If nil automatically detect the coding system."
   :type 'coding-system
+  :version "24.1"
   :group 'rcirc)
 
 (defcustom rcirc-encode-coding-system 'utf-8
@@ -1480,9 +1482,9 @@
              (old-point (point-marker))
              (fill-start (marker-position rcirc-prompt-start-marker)))
 
+         (setq text (decode-coding-string text (or rcirc-decode-coding-system
+                                                   (detect-coding-string text 
t))))
          (unless (string= sender (rcirc-nick process))
-           ;; only decode text from other senders, not ours
-           (setq text (decode-coding-string text rcirc-decode-coding-system))
            ;; mark the line with overlay arrow
            (unless (or (marker-position overlay-arrow-position)
                        (get-buffer-window (current-buffer))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]