emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r104210: * lisp/calendar/appt.el (app


From: Glenn Morris
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r104210: * lisp/calendar/appt.el (appt-time-msg-list): Doc fix.
Date: Thu, 12 May 2011 18:35:11 -0700
User-agent: Bazaar (2.3.1)

------------------------------------------------------------
revno: 104210
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Thu 2011-05-12 18:35:11 -0700
message:
  * lisp/calendar/appt.el (appt-time-msg-list): Doc fix.
modified:
  lisp/ChangeLog
  lisp/calendar/appt.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-05-13 01:31:53 +0000
+++ b/lisp/ChangeLog    2011-05-13 01:35:11 +0000
@@ -1,6 +1,7 @@
 2011-05-13  Glenn Morris  <address@hidden>
 
        * calendar/appt.el (appt-make-list): Simplify.
+       (appt-time-msg-list): Doc fix.
 
 2011-05-12  Andreas Schwab  <address@hidden>
 

=== modified file 'lisp/calendar/appt.el'
--- a/lisp/calendar/appt.el     2011-05-13 01:31:53 +0000
+++ b/lisp/calendar/appt.el     2011-05-13 01:35:11 +0000
@@ -167,16 +167,16 @@
 
 ;; TODO Turn this into an alist?  It would be easier to add more
 ;; optional elements.
-;; TODO There should be a way to set WARNTIME (and other properties)
-;; from the diary-file.  Implementing that would be a good reason
-;; to change this to an alist.
+;; Why is the first element (MINUTES) rather than just MINUTES?
+;; It may just inherit from diary-entries-list, where we have
+;; ((MONTH DAY YEAR) ENTRY)
 (defvar appt-time-msg-list nil
   "The list of appointments for today.
 Use `appt-add' and `appt-delete' to add and delete appointments.
 The original list is generated from today's `diary-entries-list', and
 can be regenerated using the function `appt-check'.
 Each element of the generated list has the form
-\(MINUTES STRING [FLAG] [WARNTIME])
+\((MINUTES) STRING [FLAG] [WARNTIME])
 where MINUTES is the time in minutes of the appointment after midnight,
 and STRING is the description of the appointment.
 FLAG and WARNTIME are not always present.  A non-nil FLAG
@@ -548,6 +548,8 @@
                          ;; Get the whole string for this appointment.
                          (appt-time-string
                           (substring time-string beg end))
+                         ;; FIXME why the list?  It makes the first
+                         ;; element (MINUTES) rather than MINUTES.
                          (appt-time (list (appt-convert-time only-time)))
                          (time-msg (append
                                     (list appt-time appt-time-string)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]