[Emacs-diffs] /srv/bzr/emacs/trunk r103968: gnus.el (gnus-registry-ignored-groups): Provide default in gnus.el, not gnus-registry.el.

[Katsumi Yamaoka]

------------------------------------------------------------
revno: 103968
author: Teodor Zlatanov <address@hidden>
committer: Katsumi Yamaoka <address@hidden>
branch nick: trunk
timestamp: Thu 2011-04-21 22:06:12 +0000
message:
  gnus.el (gnus-registry-ignored-groups): Provide default in gnus.el, not 
gnus-registry.el.
  gnus-registry.el (gnus-registry-ignored-groups): Remove defcustom.  Explain 
why in comments.
   (gnus-registry-action): Fix data-header reference to use the extra headers.  
Explain in package commentary how to add To and Cc headers to the 
gnus-extra-headers.
   (gnus-registry-ignored-groups): Adjust defaults to match the parameter.
   (gnus-registry-ignore-group-p): Adjust to take either a group/topic 
parameter list or a string list in `gnus-registry-ignored-groups'.  Fix logic 
error.
modified:
  lisp/gnus/ChangeLog
  lisp/gnus/gnus-registry.el
  lisp/gnus/gnus.el

=== modified file 'lisp/gnus/ChangeLog'
--- a/lisp/gnus/ChangeLog       2011-04-21 02:22:56 +0000
+++ b/lisp/gnus/ChangeLog       2011-04-21 22:06:12 +0000
@@ -1,3 +1,18 @@
+2011-04-21  Teodor Zlatanov  <address@hidden>
+
+       * gnus.el (gnus-registry-ignored-groups): Provide default in gnus.el,
+       not gnus-registry.el.
+
+       * gnus-registry.el (gnus-registry-ignored-groups): Remove defcustom.
+       Explain why in comments.
+       (gnus-registry-action): Fix data-header reference to use the extra
+       headers.  Explain in package commentary how to add To and Cc headers to
+       the gnus-extra-headers.
+       (gnus-registry-ignored-groups): Adjust defaults to match the parameter.
+       (gnus-registry-ignore-group-p): Adjust to take either a group/topic
+       parameter list or a string list in `gnus-registry-ignored-groups'.  Fix
+       logic error.
+
 2011-04-21  Lars Magne Ingebrigtsen  <address@hidden>
 
        * shr.el (shr-expand-url): Protect against null urls.

=== modified file 'lisp/gnus/gnus-registry.el'
--- a/lisp/gnus/gnus-registry.el        2011-04-20 22:12:08 +0000
+++ b/lisp/gnus/gnus-registry.el        2011-04-21 22:06:12 +0000
@@ -31,7 +31,16 @@
 ;; gnus-registry.el intercepts article respooling, moving, deleting,
 ;; and copying for all backends.  If it doesn't work correctly for
 ;; you, submit a bug report and I'll be glad to fix it.  It needs
-;; documentation in the manual (also on my to-do list).
+;; better documentation in the manual (also on my to-do list).
+
+;; If you want to track recipients (and you should to make the
+;; gnus-registry splitting work better), you need the To and Cc
+;; headers collected by Gnus:
+
+;; ;;; you may also want Gcc Newsgroups Keywords X-Face
+;; (add-to-list 'gnus-extra-headers 'To)
+;; (add-to-list 'gnus-extra-headers 'Cc)
+;; (setq nnmail-extra-headers gnus-extra-headers)
 
 ;; Put this in your startup file (~/.gnus.el for instance) or use Customize:
 
@@ -137,16 +146,6 @@
   :group 'gnus-registry
   :type '(repeat regexp))
 
-(defcustom gnus-registry-ignored-groups
-  '("delayed$" "drafts$" "queue$" "INBOX$" "^nnmairix:" "archive")
-  "List of groups that the Gnus Registry will ignore.
-The group names are matched, they don't have to be fully
-qualified.
-
-nnmairix groups are specifically excluded because they are ephemeral."
-  :group 'gnus-registry
-  :type '(repeat regexp))
-
 (defcustom gnus-registry-install 'ask
   "Whether the registry should be installed."
   :group 'gnus-registry
@@ -313,9 +312,10 @@
 (defun gnus-registry-action (action data-header from &optional to method)
   (let* ((id (mail-header-id data-header))
          (subject (mail-header-subject data-header))
+         (extra (mail-header-extra data-header))
          (recipients (gnus-registry-sort-addresses
-                     (or (cdr (assq "Cc" data-header)) "")
-                     (or (cdr (assq "To" data-header)) "")))
+                      (or (cdr-safe (assq 'Cc extra)) "")
+                      (or (cdr-safe (assq 'To extra)) "")))
          (sender (nth 0 (gnus-registry-extract-addresses
                          (mail-header-from data-header))))
          (from (gnus-group-guess-full-name-from-command-method from))
@@ -333,9 +333,9 @@
 (defun gnus-registry-spool-action (id group &optional subject sender 
recipients)
   (let ((to (gnus-group-guess-full-name-from-command-method group))
         (recipients (or recipients
-                       (gnus-registry-sort-addresses
-                        (or (message-fetch-field "cc") "")
-                        (or (message-fetch-field "to") ""))))
+                        (gnus-registry-sort-addresses
+                         (or (message-fetch-field "cc") "")
+                         (or (message-fetch-field "to") ""))))
         (subject (or subject (message-fetch-field "subject")))
         (sender (or sender (message-fetch-field "from"))))
     (when (and (stringp id) (string-match "\r$" id))
@@ -414,8 +414,8 @@
          (sender (gnus-string-remove-all-properties
                   (message-fetch-field "from")))
          (recipients (gnus-registry-sort-addresses
-                     (or (message-fetch-field "cc") "")
-                     (or (message-fetch-field "to") "")))
+                      (or (message-fetch-field "cc") "")
+                      (or (message-fetch-field "to") "")))
          (subject (gnus-string-remove-all-properties
                    (gnus-registry-simplify-subject
                     (message-fetch-field "subject"))))
@@ -655,17 +655,28 @@
                  group
                  nnmail-split-fancy-with-parent-ignore-groups)))))
 
+;; note that gnus-registry-ignored-groups is defined in gnus.el as a
+;; group/topic parameter and an associated variable!
+
+;; we do special logic for ignoring to accept regular expressions and
+;; nnmail-split-fancy-with-parent-ignore-groups as well
 (defun gnus-registry-ignore-group-p (group)
   "Determines if a group name should be ignored.
 Consults `gnus-registry-ignored-groups' and
 `nnmail-split-fancy-with-parent-ignore-groups'."
   (and group
-       (not (or (gnus-grep-in-list
-                 group
-                 gnus-registry-ignored-groups)
-                (gnus-grep-in-list
-                 group
-                 nnmail-split-fancy-with-parent-ignore-groups)))))
+       (or (gnus-parameter-registry-ignore group)
+           (gnus-grep-in-list
+            group
+            (delq nil (mapcar (lambda (g)
+                                (cond
+                                 ((stringp g) g)
+                                 ((and (listp g) (nth 1 g))
+                                  (nth 0 g))
+                                 (t nil))) gnus-registry-ignored-groups)))
+           (gnus-grep-in-list
+            group
+            nnmail-split-fancy-with-parent-ignore-groups))))
 
 (defun gnus-registry-wash-for-keywords (&optional force)
   "Get the keywords of the current article.
@@ -738,7 +749,7 @@
 (defun gnus-registry-sort-addresses (&rest addresses)
   "Return a normalized and sorted list of ADDRESSES."
   (sort (apply 'nconc (mapcar 'gnus-registry-extract-addresses addresses))
-       'string-lessp))
+        'string-lessp))
 
 (defun gnus-registry-simplify-subject (subject)
   (if (stringp subject)
@@ -769,7 +780,7 @@
            (assoc article (gnus-data-list nil)))
       (gnus-string-remove-all-properties
        (cdr (assq header (gnus-data-header
-                         (assoc article (gnus-data-list nil))))))
+                          (assoc article (gnus-data-list nil))))))
     nil))
 
 ;; registry marks glue
@@ -998,7 +1009,7 @@
                extra-cell key val)
           ;; remove all the strings from the entry
           (dolist (elem rest)
-           (if (stringp elem) (setq rest (delq elem rest))))
+            (if (stringp elem) (setq rest (delq elem rest))))
           (gnus-registry-set-id-key id 'group groups)
           ;; just use the first extra element
           (setq rest (car-safe rest))

=== modified file 'lisp/gnus/gnus.el'
--- a/lisp/gnus/gnus.el 2011-04-15 12:42:51 +0000
+++ b/lisp/gnus/gnus.el 2011-04-21 22:06:12 +0000
@@ -1875,7 +1875,10 @@
  :function-document
  "Whether this group should be ignored by the registry."
  :variable gnus-registry-ignored-groups
- :variable-default nil
+ :variable-default (mapcar
+                    (lambda (g) (list g t))
+                    '("delayed$" "drafts$" "queue$" "INBOX$"
+                      "^nnmairix:" "archive"))
  :variable-document
  "*Groups in which the registry should be turned off."
  :variable-group gnus-registry