emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r103830: Remove extraneous messages i


From: Chong Yidong
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r103830: Remove extraneous messages in 2011-03-30 completion change.
Date: Tue, 05 Apr 2011 17:19:42 -0400
User-agent: Bazaar (2.0.3)

------------------------------------------------------------
revno: 103830
committer: Chong Yidong <address@hidden>
branch nick: trunk
timestamp: Tue 2011-04-05 17:19:42 -0400
message:
  Remove extraneous messages in 2011-03-30 completion change.
  These blocked the minibuffer contents when completing in the minibuffer, in a
  departure from previous Emacs behavior.
  
  * lisp/minibuffer.el (completion-in-region--postch)
  (completion-in-region-mode): Remove unnecessary messages.
modified:
  lisp/ChangeLog
  lisp/minibuffer.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-04-05 15:20:21 +0000
+++ b/lisp/ChangeLog    2011-04-05 21:19:42 +0000
@@ -1,3 +1,8 @@
+2011-04-05  Chong Yidong  <address@hidden>
+
+       * minibuffer.el (completion-in-region--postch)
+       (completion-in-region-mode): Remove unnecessary messages.
+
 2011-04-05  Juanma Barranquero  <address@hidden>
 
        * font-lock.el (font-lock-refresh-defaults):

=== modified file 'lisp/minibuffer.el'
--- a/lisp/minibuffer.el        2011-04-01 17:19:52 +0000
+++ b/lisp/minibuffer.el        2011-04-05 21:19:42 +0000
@@ -1278,7 +1278,6 @@
 ;; - pcomplete: pop it down on SPC or after some time-delay.
 ;; - semantic: use a post-command-hook check similar to this one.
 (defun completion-in-region--postch ()
-  (message "completion-in-region--postch: cmd=%s" this-command)
   (or unread-command-events ;Don't pop down the completions in the middle of
                             ;mouse-drag-region/mouse-set-point.
       (and completion-in-region--data
@@ -1310,10 +1309,8 @@
         (delq (assq 'completion-in-region-mode minor-mode-overriding-map-alist)
               minor-mode-overriding-map-alist))
   (if (null completion-in-region-mode)
-      (progn
-        (unless (equal "*Completions*" (buffer-name (window-buffer)))
-          (minibuffer-hide-completions))
-        (message "Leaving completion-in-region-mode"))
+      (unless (equal "*Completions*" (buffer-name (window-buffer)))
+       (minibuffer-hide-completions))
     ;; (add-hook 'pre-command-hook #'completion-in-region--prech)
     (add-hook 'post-command-hook #'completion-in-region--postch)
     (push `(completion-in-region-mode . ,completion-in-region-mode-map)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]